Hermes migration: add blockchain check for open channel - #5226
Merged
Conversation
Add initial check to blockchain. If channel is open mark as migrated and skip
n10ty
marked this pull request as ready for review
June 20, 2022 08:48
n10ty
requested review from
Guillembonet,
Snawoot,
Waldz,
mdomasevicius,
soffokl,
tadaskay and
tomasmik
as code owners
June 20, 2022 08:48
n10ty
changed the title
added 2 commits
June 20, 2022 17:36
When check whether channel is open - do it in bc first, do not rely on Transactor If user register on new hermes mark identity as skip for migration
Fix test
tomasmik
suggested changes
Jun 21, 2022
tomasmik
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For freshly registered users:
For users who are using old Hermes: