Prevent code from a panic if dns list is empty - #5252
Merged
Conversation
Signed-off-by: Andrey <andreyt@mysterium.network>
andrey-mysterium
requested review from
Guillembonet,
Snawoot,
Waldz,
mdomasevicius,
n10ty,
soffokl,
tadaskay and
tomasmik
as code owners
June 28, 2022 15:40
Snawoot
suggested changes
Jun 28, 2022
Snawoot
left a comment
Snawoot
left a comment
Contributor
There was a problem hiding this comment.
Will still panic if cfg.DNS slice nil or empty.
Codecov Report
@@ Coverage Diff @@
## master #5252 +/- ##
==========================================
- Coverage 38.44% 38.00% -0.45%
==========================================
Files 358 361 +3
Lines 19561 19798 +237
==========================================
+ Hits 7521 7524 +3
- Misses 11302 11530 +228
- Partials 738 744 +6
Continue to review full report at Codecov.
|
Snawoot
self-requested a review
June 28, 2022 16:36
Snawoot
approved these changes
Jun 28, 2022
soffokl
approved these changes
Jun 29, 2022
| @@ -0,0 +1,65 @@ | |||
| /* | |||
| * Copyright (C) 2018 The "MysteriumNetwork/node" Authors. | |||
Member
There was a problem hiding this comment.
For new files, this should be set to the current date.
Suggested change
| * Copyright (C) 2018 The "MysteriumNetwork/node" Authors. | |
| * Copyright (C) 2022 The "MysteriumNetwork/node" Authors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrey andreyt@mysterium.network