Introduce new services - #5321
Merged
Merged
Conversation
yeszhanov95
requested review from
Guillembonet,
Snawoot,
Waldz,
mdomasevicius,
n10ty,
soffokl,
tadaskay and
tomasmik
as code owners
July 21, 2022 09:30
n10ty
approved these changes
Jul 21, 2022
soffokl
reviewed
Jul 21, 2022
| // Other services could be started only explicitly. | ||
| serviceTypes := []string{wireguard.ServiceType} | ||
| // If no service type specified we are starting wireguard, scraping and data_transfer. | ||
| serviceTypes := []string{wireguard.ServiceType, scraping.ServiceType, data_transfer.ServiceType} |
Member
There was a problem hiding this comment.
Let's not start it automatically now. We need to prepare other components for it.
Later we will enable it for sure.
|
|
||
| // Ideally api should allow to pass multiple service types to skip noop | ||
| // proposals, but for now just filter in memory. | ||
| serviceTypesDict := map[string]bool{ |
Member
There was a problem hiding this comment.
Just serviceTypes without Dict will be the same clear but shorter. We already know that this is a map, no need to put it into the variable name.
Codecov Report
@@ Coverage Diff @@
## master #5321 +/- ##
==========================================
- Coverage 38.67% 38.57% -0.11%
==========================================
Files 356 356
Lines 19450 19455 +5
==========================================
- Hits 7523 7505 -18
- Misses 11185 11206 +21
- Partials 742 744 +2
Continue to review full report at Codecov.
|
soffokl
approved these changes
Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new service types, namely: scraping and data_transfer. These new services will be enabled later, when we prepare all components.
New services could be accessed only by whitelisted consumers.
As for now, all the three services have the same pricing, later I will set up for each individually.
According to #5262