Feature/run openvpn on mobile android - #534
Merged
Merged
Conversation
tadovas
force-pushed
the
feature/run-openvpn-on-mobile-android
branch
from
November 13, 2018 06:48
5e7fc02 to
eb6536f
Compare
soffokl
reviewed
Nov 13, 2018
soffokl
reviewed
Nov 13, 2018
| var buff = &bytes.Buffer{} | ||
| fmt.Fprintln(buff, "-----BEGIN OpenVPN Static key V1-----") | ||
| left := key | ||
| for { |
Member
There was a problem hiding this comment.
can't we do it like this?
for left := key; len(left) > 64; left = left[64:] {
fmt.Fprintln(buff, left[0:64])
}
fmt.Fprintln(buff, left)
Contributor
Author
There was a problem hiding this comment.
Yes we can. Also we can write additional test for this code part. Done
vkuznecovas
previously approved these changes
Nov 13, 2018
soffokl
reviewed
Nov 13, 2018
soffokl
left a comment
soffokl
left a comment
Member
There was a problem hiding this comment.
Sorry, missed this on the first walkthrough.
|
|
||
| // TODO Make Openvpn pluggable connection optional | ||
| Openvpn: noOpenvpnYet{}, | ||
| Openvpn: embbededLibCheck{}, |
Member
There was a problem hiding this comment.
Suggested change
| Openvpn: embbededLibCheck{}, | |
| Openvpn: embeddedLibCheck{}, |
| } | ||
|
|
||
| type noOpenvpnYet struct { | ||
| type embbededLibCheck struct { |
Member
There was a problem hiding this comment.
Suggested change
| type embbededLibCheck struct { | |
| type embeddedLibCheck struct { |
|
|
||
| func (noOpenvpnYet) Check() error { | ||
| // Check always returns nil as embedded lib does not have any external failing deps | ||
| func (embbededLibCheck) Check() error { |
Member
There was a problem hiding this comment.
Suggested change
| func (embbededLibCheck) Check() error { | |
| func (embeddedLibCheck) Check() error { |
| // BinaryPath returns noop binary path | ||
| func (noOpenvpnYet) BinaryPath() string { | ||
| return "no openvpn binary available on mobile" | ||
| func (embbededLibCheck) BinaryPath() string { |
Member
There was a problem hiding this comment.
Suggested change
| func (embbededLibCheck) BinaryPath() string { | |
| func (embeddedLibCheck) BinaryPath() string { |
|
|
||
| var _ node.Openvpn = noOpenvpnYet{} | ||
| // check if our struct satisfies Openvpn interface expected by node options | ||
| var _ node.Openvpn = embbededLibCheck{} |
Member
There was a problem hiding this comment.
Suggested change
| var _ node.Openvpn = embbededLibCheck{} | |
| var _ node.Openvpn = embeddedLibCheck{} |
| type MobileNode struct { | ||
| di cmd.Dependencies | ||
| di cmd.Dependencies | ||
| identity identity.Identity |
Member
There was a problem hiding this comment.
identity is unused now, is it for future usage?
tadovas
force-pushed
the
feature/run-openvpn-on-mobile-android
branch
from
November 13, 2018 09:33
e428c92 to
c75a800
Compare
soffokl
approved these changes
Nov 13, 2018
vkuznecovas
approved these changes
Nov 13, 2018
zolia
approved these changes
Nov 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description says it all.
Closes #364