Skip to content

#5338 beneficiary info - #5340

Merged
n10ty merged 3 commits into
masterfrom
5338-beneficiary-info
Jul 27, 2022
Merged

#5338 beneficiary info#5340
n10ty merged 3 commits into
masterfrom
5338-beneficiary-info

Conversation

@n10ty

@n10ty n10ty commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Print verbose error. If there are no beneficiary changes do not throw an error, but return not_found status instead.

AndreyM added 2 commits July 27, 2022 12:55
Print verbose error. If there are no beneficiary changes do not throw an error, but return not_found status instead.
Update go-rest to 0.3.1
@n10ty
n10ty marked this pull request as ready for review July 27, 2022 10:26
Comment thread cmd/commands/cli/command_identities.go Outdated
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #5340 (6eba73b) into master (203c8ed) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5340      +/-   ##
==========================================
- Coverage   38.61%   38.53%   -0.09%     
==========================================
  Files         357      357              
  Lines       19524    19531       +7     
==========================================
- Hits         7539     7526      -13     
- Misses      11243    11261      +18     
- Partials      742      744       +2     
Impacted Files Coverage Δ
core/beneficiary/change_keeper.go 51.28% <ø> (ø)
tequilapi/endpoints/transactor.go 38.84% <0.00%> (-0.77%) ⬇️
requests/dialer_swarm.go 72.18% <0.00%> (-3.76%) ⬇️
nat/traversal/pinger.go 76.74% <0.00%> (-3.49%) ⬇️
p2p/channel.go 66.06% <0.00%> (-0.73%) ⬇️
tequilapi/endpoints/sse_handler.go 70.62% <0.00%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203c8ed...6eba73b. Read the comment docs.

@n10ty
n10ty merged commit dc9f0fd into master Jul 27, 2022
@n10ty
n10ty deleted the 5338-beneficiary-info branch July 27, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants