Mobile node connections configuration is optional now - #565
Merged
Conversation
…e types, use separate specific methods instead
Contributor
Author
|
Ping @donce as these gonna API breaking changes. Nothing super complicated, but still... |
vkuznecovas
approved these changes
Nov 22, 2018
zolia
reviewed
Nov 22, 2018
| type WireguardTunnelSetup tunnSetupPlaceholder | ||
|
|
||
| // OverrideWireguardConnection overrides default wireguard connection implementation to more mobile adapted one | ||
| func (mobNode *MobileNode) OverrideWireguardConnection(wgTunnelSetup WireguardTunnelSetup) { |
Contributor
There was a problem hiding this comment.
Why to call it Override? Its simple connection through our bridge.
Contributor
Author
There was a problem hiding this comment.
Because it exactly what it does - overrides default "openvpn" connection configured in node
zolia
reviewed
Nov 22, 2018
| type Openvpn3TunnelSetup openvpn3.TunnelSetup | ||
|
|
||
| // OverrideOpenvpnConnection replaces default openvpn connection factory with mobile related one | ||
| func (mobNode *MobileNode) OverrideOpenvpnConnection(tunnelSetup Openvpn3TunnelSetup) { |
Contributor
There was a problem hiding this comment.
Maybe we can call it MobileOpenvpnConnection. From user standpoint he is not overriding anything..
Contributor
Author
There was a problem hiding this comment.
See my comment above
zolia
approved these changes
Nov 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing new mobile specific service configuration should not affect existing clients (to some extent)
Bonus: @Waldz can now roam freely between wifi and 4G :)