simplified the statistics channel adapter for mobile openvpn - #576
Merged
Conversation
tadovas
previously approved these changes
Nov 27, 2018
tadovas
left a comment
tadovas
left a comment
Contributor
There was a problem hiding this comment.
Awesome 👍 I like deleted/added lines ratio 29 to 6 :)
soffokl
previously approved these changes
Nov 27, 2018
soffokl
left a comment
soffokl
left a comment
Member
There was a problem hiding this comment.
I really like things like this! :)
Contributor
|
We need to add refactoring the same daily task as test writting. Boy scout rule - leave a place cleaner than you found it |
Contributor
|
Rebase please :) |
vkuznecovas
force-pushed
the
fix-the-mess-i-made
branch
from
November 27, 2018 12:25
4b394ce to
5d9e8c9
Compare
tadovas
approved these changes
Nov 27, 2018
soffokl
approved these changes
Nov 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES #573
Got rid of the unneeded struct and pass data to the statistics channel straight away.