Skip to content

Revert "Use the latest version of wireguard-go (052af4a8 3/25/2023)" - #5855

Merged
soffokl merged 2 commits into
masterfrom
fix/wg-close-conn
Aug 15, 2023
Merged

Revert "Use the latest version of wireguard-go (052af4a8 3/25/2023)"#5855
soffokl merged 2 commits into
masterfrom
fix/wg-close-conn

Conversation

@Zensey

@Zensey Zensey commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

This reverts commit 80de027

This reverts commit 80de027

Signed-off-by: Anton Litvinov <jnashicq@gmail.com>
@Snawoot

Snawoot commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Any explaination why we would want that?

@Zensey

Zensey commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

@Snawoot

1.20.1...1.20.2
here was introduced a bug that kills our monitoring agent/superproxy
I see that wireguard package was updated, but looks like it’s not working as expected
so monitoring agent creates a lot of connections, disconnects from it, and looks like it’s not releasing properly and the connection cannot be reused anymore

btw, this is a blocker to start using dvpn service

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #5855 (3a44260) into master (8d9e3d5) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #5855      +/-   ##
==========================================
- Coverage   37.60%   37.50%   -0.11%     
==========================================
  Files         373      373              
  Lines       20769    20769              
==========================================
- Hits         7810     7789      -21     
- Misses      12184    12203      +19     
- Partials      775      777       +2     

see 5 files with indirect coverage changes

@soffokl soffokl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these changes affect? Can we just revert it with no issues?

@soffokl soffokl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a test, this seems to be solved the issue.

@soffokl

soffokl commented Aug 14, 2023

Copy link
Copy Markdown
Member

@Zensey please merge it.

@soffokl
soffokl merged commit 7f5bf0b into master Aug 15, 2023
@soffokl
soffokl deleted the fix/wg-close-conn branch August 15, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants