Allow localhost-only routes to be used from host - #5867
Merged
Conversation
Zensey
requested review from
Guillembonet,
Snawoot,
Waldz,
mdomasevicius,
n10ty,
soffokl and
tadaskay
as code owners
August 29, 2023 12:34
Snawoot
suggested changes
Aug 29, 2023
Snawoot
left a comment
Snawoot
left a comment
Contributor
There was a problem hiding this comment.
Ask @mdomasevicius for details. Should work in docker with 127.0.0.1 as well.
Zensey
force-pushed
the
fix/id-export-docker
branch
from
August 29, 2023 15:18
e1c0df9 to
af3e07b
Compare
…docker Signed-off-by: Anton Litvinov <jnashicq@gmail.com>
Zensey
force-pushed
the
fix/id-export-docker
branch
from
August 29, 2023 15:19
af3e07b to
389a782
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #5867 +/- ##
==========================================
- Coverage 37.51% 37.50% -0.02%
==========================================
Files 373 373
Lines 20796 20797 +1
==========================================
- Hits 7802 7800 -2
- Misses 12217 12224 +7
+ Partials 777 773 -4
|
Signed-off-by: Anton Litvinov <jnashicq@gmail.com>
Snawoot
approved these changes
Aug 31, 2023
Zensey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding the case when node is run on docker. When a request comes from 172.17.0.1 it could be sent not neccessarily from host, there are many possibilities.