Feature/wg mobile side - #591
Merged
Merged
Conversation
tadovas
commented
Nov 30, 2018
tadovas
commented
Contributor
- Add skeleton for wg tunnel setup for mobile side
- Enable userspace wg usage in oses other than linux (darwin, win etc.)
soffokl
reviewed
Dec 3, 2018
| } | ||
|
|
||
| func (wg *wireguardConnection) doInit() error { | ||
| wg.closed.Add(1) |
Member
There was a problem hiding this comment.
We are adding 1 to closed in the init func. Something wrong with naming here. Maybe it should be active instead of closed?
Contributor
Author
There was a problem hiding this comment.
This is how WaitGroup works, this group expresses everything stopped condition. So yes add 1 is at init. Done is where shutdown completes. Renamed to stopCompleted if it makes more sense, but for me personally it's just cosmetics
zolia
reviewed
Dec 3, 2018
zolia
reviewed
Dec 3, 2018
zolia
reviewed
Dec 3, 2018
vkuznecovas
reviewed
Dec 3, 2018
tadovas
force-pushed
the
feature/wg-mobile-side
branch
from
December 4, 2018 11:41
314f75c to
fd5332b
Compare
tadovas
force-pushed
the
feature/wg-mobile-side
branch
7 times, most recently
from
December 6, 2018 09:52
7d31d3c to
2d8dc92
Compare
zolia
reviewed
Dec 6, 2018
zolia
reviewed
Dec 6, 2018
zolia
reviewed
Dec 6, 2018
| RemoteEndpoint: parsed, | ||
| KeepAlivePeriod: 60, | ||
| //all traffic through this peer (unfortunatelly 0.0.0.0/0 didn't work as it was treated as ipv6) | ||
| AllowedIPs: []string{"0.0.0.0/1", "128.0.0.0/1"}, |
Contributor
There was a problem hiding this comment.
These should be arbitrary modifiable. We should be getting those from a user somewhere.
Contributor
Author
There was a problem hiding this comment.
In the long perspective - maybe. At the moment - I don't think it's worth the effort.
tadovas
force-pushed
the
feature/wg-mobile-side
branch
from
December 7, 2018 08:59
8a55047 to
8cf24b3
Compare
zolia
approved these changes
Dec 7, 2018
vkuznecovas
approved these changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.