Handle team filters for empty search - #489
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts the Bleve-backed search behavior so that empty search queries use an explicit filter.teams scope when provided, while still falling back to the user’s team defaults when no team filter is given. This fits the internal/search package’s responsibility for shaping query semantics and ranking before converting hits into GraphQL nodes.
Changes:
- Change empty-query behavior to scope results by
filter.Teamswhen provided; otherwise use the user’s team slugs (and return empty when neither exists). - Preserve empty-query kind boosting (TEAM before APPLICATION/JOB/…) for explicit team-scoped searches.
- Add focused unit tests covering explicit team scope for empty search, type filtering, and ranking.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/search/bleve.go | Updates empty-query scoping logic and factors team filtering into a helper disjunction query. |
| internal/search/bleve_test.go | Adds unit tests for team-scoped empty search behavior, type filtering, and ranking order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter.teamsas the scope for empty search queriesTesting
rtk go test ./internal/searchrtk mise run test:unitrtk mise run fmt