feat(ensindexer): introduce label healing from reverse registry by tk-o · Pull Request #362 · namehash/ensnode

tk-o · 2025-03-10T19:32:07Z

closes #204

Suggested review order

Review package/ensnode-utils updates.
Review apps/ensindexer/src/lib updates.
Review apps/ensindexer/src/plugins updates.
Review apps/ensindexer/src/handlers updates
Review ponder.config.ts updates.

Scope

This PR introduces a feature of healing labels based on reverse addresses. This feature can be toggled on and off, by setting to HEAL_REVERSE_ADDRESSES to true or false, respectively. Please note, that only the eth plugin is going to support the new feature, while base and linea plugins will not.

To complete the feature, I had to:

create a parser for HEAL_REVERSE_ADDRESSES env var;
update the ponder plugin handler args type, to include plugin-defined helper methods canHealReverseAddresses and isReverseRootNode;
have all plugins to provide implementations for new helper methods (some of them throw error just to manifest lack of support for the feature in question);
update generic handlers handleNameRegistered & handleNewOwner to attempt reverse address label healing before attempting ENSRainbow label healing;
make ponder config object value altered based of HEAL_REVERSE_ADDRESSES env var value

Pre-merge checklist

ensure every ENSIndexer and ENSApi service that runs with only eth plugin on has HEAL_REVERSE_ADDRESSES set to false

Post-merge checklist

create an issue for handling errors thrown by labelByReverseAddress call
- if the function in question throws an error, it means the input params provided directly from event arguments were incorrect — in this case, we need to let the indexing process to crash so we could be notified about unexpected data
create an issue for healing addr.reverse subnames for non-mainnet chains
- Allow healing addr.reverse subnames for non-mainnet chains #544
create an issue for feat(ensindexer): introduce label healing from reverse registry #362 (comment)
- ENSAdmin: Show Contract start/end blockranges in indexing status ui #531
create an issue for feat(ensindexer): introduce label healing from reverse registry #362 (comment)
- Collect data about failed attempts of healing addr.reverse subnames #545

Resolves #204

Uses reverse registry records to heal label from transaction sender address

vercel · 2025-03-10T19:32:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
admin.ensnode.io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 8, 2025 9:48pm
ensadmin-next	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 8, 2025 9:48pm
ensnode.io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 8, 2025 9:48pm
ensrainbow.io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 8, 2025 9:48pm

…stry-subnames-auto-healing

apps/ensindexer/src/handlers/Registry.ts

…stry-subnames-auto-healing

Only the eth plugin uses the env-based feature flag, while other plugins have reverse addresses healing turned off

…stry-subnames-auto-healing

Simplify indexing handlers code and move extra complexity to config file for each plugin.

…stry-subnames-auto-healing

lightwalker-eth

@tk-o Thanks for updates. Reviewed and shared feedback!

packages/ensnode-utils/src/subname-helpers.ts

lightwalker-eth · 2025-04-07T08:18:45Z

packages/ensnode-utils/src/subname-helpers.ts

@@ -17,6 +21,63 @@ export const ROOT_NODE = namehash("");

 export const makeSubnodeNamehash = (node: Hex, label: Hex) => keccak256(concat([node, label]));


Why are we using the word label here? This is NOT a label! It is a labelhash! I've flagged this issue and the importance of fixing it multiple times over several months.

@shrugs is that change going to be covered in your PR?

Refine Terminology Use / Refactor Naming #532

packages/ensnode-utils/src/subname-helpers.ts

apps/ensindexer/ponder.config.ts

apps/ensindexer/.env.local.example

lightwalker-eth · 2025-04-07T08:52:43Z

apps/ensindexer/.env.local.example

+#
+# WARNING: Setting this to `true` results in indexed data no longer being backwards compatible with the ENS Subgraph. For full
+# data-level backwards compatibility with the ENS Subgraph, set this to `false`.
+HEAL_REVERSE_ADDRESSES=true


Whenever we add configs that influence indexing behaviour, visibility of how these configs are set needs to be added to the indexing status dashboard in ENSAdmin.

lightwalker-eth · 2025-04-07T08:54:54Z

apps/ensindexer/src/handlers/Registry.ts

+
+          // if healing label from reverse addresses is possible, give it a go
+          if (canHealReverseAddressFromParentNode(node)) {
+            // TODO: if healing failed, log the event args for analysis and debugging


Seems nice for us to do this and then investigate these logs and see if we can identify patterns to better heal more of these cases?

Logged as:

Collect data about failed attempts of healing addr.reverse subnames #545

apps/ensindexer/src/handlers/Registry.ts

lightwalker-eth

Small language refinement suggested

packages/ensnode-utils/src/constants.ts

Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>

tk-o · 2025-04-09T10:29:42Z

apps/ensindexer/src/lib/ponder-helpers.ts

+  if (!rawValue) return DEFAULT_HEAL_REVERSE_ADDRESSES;
+  if (rawValue === "true") return true;
+  if (rawValue === "false") return false;


Very simple, nice 👍

tk-o · 2025-04-09T10:34:53Z

packages/ensnode-utils/src/constants.ts

+ * Useful for identifying if a domain is used for reverse resolution.
+ * See apps/ensindexer/src/handlers/Registry.ts for context.
+ */
+export const REVERSE_ROOT_NODES: Set<Node> = new Set([namehash("addr.reverse")]);


This will enable healing reverse addresses for both, eth plugin, and linea plugin. This is due to Linea ENS implementation currently not following ENSIP-19 specs.

I believe the goal of this PR was to enable healing process for eth plugin only.

For context:

Implement ENSIP-19 for ReverseRegistrar Consensys/linea-ens#287

Logged with:

Enable label healing from reverse registry exclusively on mainnet #616

feat(ensindexer): introduce label healing from reverse registry

78c07fe

Uses reverse registry records to heal label from transaction sender address

Merge remote-tracking branch 'origin/main' into feat/204-reverse-regi…

02bd5bf

…stry-subnames-auto-healing

vercel bot temporarily deployed to Preview – ensadmin-next March 10, 2025 19:33 Inactive

vercel bot deployed to Preview – ensrainbow.io March 10, 2025 19:34 View deployment

vercel bot deployed to Preview – ensnode.io March 10, 2025 19:34 View deployment

vercel bot deployed to Preview – admin.ensnode.io March 10, 2025 19:35 View deployment

fix(ensindexer): update eth plugin reverse root config

7ac7db3

vercel bot deployed to Preview – ensrainbow.io March 10, 2025 20:06 View deployment

vercel bot temporarily deployed to Preview – ensadmin-next March 10, 2025 20:07 Inactive

vercel bot deployed to Preview – admin.ensnode.io March 10, 2025 20:08 View deployment

vercel bot deployed to Preview – ensnode.io March 10, 2025 20:09 View deployment

djstrong reviewed Mar 10, 2025

View reviewed changes

apps/ensindexer/src/handlers/Registry.ts Outdated Show resolved Hide resolved

tk-o added 2 commits March 11, 2025 07:50

Merge remote-tracking branch 'origin/main' into feat/204-reverse-regi…

49d5aaf

…stry-subnames-auto-healing

refactor(ensindexer): allow plugins to control feature flag

bcf50d4

Only the eth plugin uses the env-based feature flag, while other plugins have reverse addresses healing turned off

vercel bot deployed to Preview – ensnode.io March 11, 2025 12:13 View deployment

vercel bot deployed to Preview – admin.ensnode.io March 11, 2025 12:13 View deployment

vercel bot temporarily deployed to Preview – ensadmin-next March 11, 2025 12:14 Inactive

vercel bot deployed to Preview – ensrainbow.io March 11, 2025 12:15 View deployment

djstrong approved these changes Mar 11, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into feat/204-reverse-regi…

b1846c9

…stry-subnames-auto-healing

vercel bot deployed to Preview – admin.ensnode.io March 11, 2025 17:30 View deployment

vercel bot deployed to Preview – ensrainbow.io March 11, 2025 17:31 View deployment

vercel bot deployed to Preview – ensnode.io March 11, 2025 17:32 View deployment

vercel bot temporarily deployed to Preview – ensadmin-next March 11, 2025 17:33 Inactive

tk-o added 2 commits March 12, 2025 16:03

refactor(ensindexer): reverse addr label healing

42af477

Simplify indexing handlers code and move extra complexity to config file for each plugin.

Merge remote-tracking branch 'origin/main' into feat/204-reverse-regi…

41d6813

…stry-subnames-auto-healing

vercel bot deployed to Preview – admin.ensnode.io March 12, 2025 15:04 View deployment

vercel bot temporarily deployed to Preview – ensadmin-next March 12, 2025 15:05 Inactive

vercel bot deployed to Preview – ensnode.io March 12, 2025 15:06 View deployment

vercel bot deployed to Preview – admin.ensnode.io April 6, 2025 08:47 View deployment

vercel bot deployed to Preview – ensnode.io April 6, 2025 08:47 View deployment

lightwalker-eth requested changes Apr 7, 2025

View reviewed changes

fix: review comments, simplify integration in prep for naming refactor

58c6570

vercel bot deployed to Preview – ensnode.io April 8, 2025 17:52 View deployment

vercel bot deployed to Preview – admin.ensnode.io April 8, 2025 17:53 View deployment

vercel bot deployed to Preview – ensrainbow.io April 8, 2025 17:54 View deployment

shrugs added 2 commits April 8, 2025 13:06

feat: simoplify implementation further

fce408e

fix: remove console.log

ef020b1

vercel bot deployed to Preview – ensnode.io April 8, 2025 18:09 View deployment

vercel bot deployed to Preview – ensrainbow.io April 8, 2025 18:09 View deployment

vercel bot deployed to Preview – admin.ensnode.io April 8, 2025 18:10 View deployment

fix: remove per-plugin reverse root node logic

5673eba

vercel bot deployed to Preview – admin.ensnode.io April 8, 2025 18:20 View deployment

vercel bot deployed to Preview – ensrainbow.io April 8, 2025 18:21 View deployment

shrugs added 3 commits April 8, 2025 13:21

fix: updates

0d067ac

Merge branch 'main' into feat/204-reverse-registry-subnames-auto-healing

368bb08

Merge branch 'main' into feat/204-reverse-registry-subnames-auto-healing

811c66b

lightwalker-eth reviewed Apr 8, 2025

View reviewed changes

packages/ensnode-utils/src/constants.ts Outdated Show resolved Hide resolved

packages/ensnode-utils/src/constants.ts Outdated Show resolved Hide resolved

lightwalker-eth approved these changes Apr 8, 2025

View reviewed changes

shrugs and others added 2 commits April 8, 2025 16:42

Update packages/ensnode-utils/src/constants.ts

e996c08

Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>

Update packages/ensnode-utils/src/constants.ts

5aabb5f

Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>

This was referenced Apr 8, 2025

chore(release): version apps #536

Closed

chore(release): version apps #539

Merged

chore(release): version apps #541

Closed

chore(release): version apps #542

Closed

tk-o commented Apr 9, 2025

View reviewed changes

tk-o mentioned this pull request Apr 9, 2025

Allow healing addr.reverse subnames for non-mainnet chains #544

Closed

tk-o mentioned this pull request Apr 16, 2025

Enable label healing from reverse registry exclusively on mainnet #616

Closed

		@@ -17,6 +21,63 @@ export const ROOT_NODE = namehash("");

		export const makeSubnodeNamehash = (node: Hex, label: Hex) => keccak256(concat([node, label]));

Conversation

tk-o commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Suggested review order

Scope

Pre-merge checklist

Post-merge checklist

Uh oh!

vercel bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

lightwalker-eth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lightwalker-eth Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

tk-o Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lightwalker-eth Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

shrugs Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

lightwalker-eth Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

tk-o Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lightwalker-eth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tk-o Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

tk-o Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tk-o Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tk-o commented Mar 10, 2025 •

edited

Loading

vercel bot commented Mar 10, 2025 •

edited

Loading

tk-o Apr 9, 2025 •

edited

Loading

tk-o Apr 9, 2025 •

edited

Loading