Merged
Conversation
New master version following the annual upgrade of the CMEMS neXtSIM-F forecast.
The if-condition chooses to use either -isystem or -I, depending on the value of $BOOST_DIR. This is sub-optimal, but works. We should investigate better the use of -isystem.
Address issue #612 by including an if-condition in model/Makefile
add break to melt_type 2
This addresses issue #634, by adding I (the penetrating short-wave radiation) as an output to IABulkFluxes and using this in the Winton and Semtner models.
The value of I_0 is quite uncertain it seems, but let's use the Winton (2000) value for now (30%).
I put the arguments in the wrong place in the IABulkFlux function, compared to the call. This is fixed. I also added t1 and t2 as output variables for the moorings.
Member
Author
|
Asking @timspainNERSC to review, as this is basically a re-implementation of what I did in neXtSIM_DG ... and to be sure that his comparison of the two models gave ok results. |
timspainNERSC
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue links back to the neXtSIM_DG issue #320:
This pull request is the fix in neXtSIM Lagrangian. I've tested the neXtSIM_DG version against Winton's results, and @timspainNERSC has compared neXtSIM_DG and neXtSIM Lagrangian outputs.