Skip to content

Issue634 pen sw#641

Merged
einola merged 9 commits intodevelopfrom
issue634_pen_sw
Jul 22, 2023
Merged

Issue634 pen sw#641
einola merged 9 commits intodevelopfrom
issue634_pen_sw

Conversation

@einola
Copy link
Copy Markdown
Member

@einola einola commented Jul 21, 2023

This issue links back to the neXtSIM_DG issue #320:

There are errors in the neXtSIM Lagrangian implementation of the Winton (2000) and Semtner (1976) thermodynamics models.

  • In the Winton model, I use "I = I_0*Qsw" without taking into account that I_0 is 0 with (thick enough) snow cover
  • In the Semtner model, I don't apply the gamma fudge factor, and only the beta fudge factor through the albedo scheme - but not the one we usually use.

Both errors stem from improper treatment of the penetration of short-wave radiation into the ice, so a fix to both fits together.

These are being addressed in neXtSIM Lagrangian by adding I (the penetrating short-wave radiation) as an output to IABulkFluxes and using this in the Winton and Semtner models. A similar approach should be taken in neXtSIM_DG.

This pull request is the fix in neXtSIM Lagrangian. I've tested the neXtSIM_DG version against Winton's results, and @timspainNERSC has compared neXtSIM_DG and neXtSIM Lagrangian outputs.

einola and others added 9 commits September 7, 2022 14:34
New master version following the annual upgrade of the CMEMS neXtSIM-F forecast.
The if-condition chooses to use either -isystem or -I, depending on the
value of $BOOST_DIR. This is sub-optimal, but works. We should
investigate better the use of -isystem.
Address issue #612 by including an if-condition in model/Makefile
This addresses issue #634, by adding I (the penetrating short-wave
radiation) as an output to IABulkFluxes and using this in the Winton and
Semtner models.
The value of I_0 is quite uncertain it seems, but let's use the Winton
(2000) value for now (30%).
I put the arguments in the wrong place in the IABulkFlux function,
compared to the call. This is fixed. I also added t1 and t2 as output
variables for the moorings.
@einola einola requested a review from timspainNERSC July 21, 2023 10:01
@einola
Copy link
Copy Markdown
Member Author

einola commented Jul 21, 2023

Asking @timspainNERSC to review, as this is basically a re-implementation of what I did in neXtSIM_DG ... and to be sure that his comparison of the two models gave ok results.

@einola einola merged commit 895d5e7 into develop Jul 22, 2023
@einola einola deleted the issue634_pen_sw branch July 22, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants