Skip to content

Fix #494, PSP RTEMS typo fix - #495

Merged
elizabash merged 1 commit into
nasa:devfrom
elizabash:dev
Jul 27, 2026
Merged

Fix #494, PSP RTEMS typo fix#495
elizabash merged 1 commit into
nasa:devfrom
elizabash:dev

Conversation

@elizabash

@elizabash elizabash commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Checklist (Please check before submitting)

Describe the contribution
This is a typo fix (for Fix #494). The error appears when compiling a fresh copy of coreFlight using the OS Ubuntu 26.04 (Resolute Raccoon), the newest release of Ubuntu. This compiling error did not appear in previous versions of Ubuntu like 22.04 (Jammy Jellyfish) or 24.04 (Noble Numbat). It also doesn't show up in Red Hat.

Testing performed
Steps taken to test the contribution:

  1. git clone https://github.com/nasa/cFS.git
  2. cd cFS
  3. git submodule init
  4. git submodule update
  5. make distclean
  6. make native_std.prep (or make native_eds.prep)
  7. make native_std.install (or make native_eds.install)

Expected behavior changes
Before, compiling a fresh copy of coreFlight while using Ubuntu Resolute Racoon, the following error would happen:

624538785-14eeb859-1f6f-4f86-bb0c-26c5a4a5f64c

Code snips
https://github.com/nasa/PSP/blob/ce9126a61dd9233d6b33b92b9e65fca9989e7d5c/unit-test-coverage/ut-stubs/override_inc/rtems/score/todimpl.h

#ifndef OVERRIDE_TOOIMPL_H
#define OVERRIDE_TODIMPL_H

There is a typo here. The D and O in TODIMPL look so close.

After changing the typo, the code compiles correctly on Resolute Raccoon.

@elizabash elizabash self-assigned this Jul 21, 2026
@elizabash

Copy link
Copy Markdown
Contributor Author

Static analysis/cppcheck failing is apparently a bug.

Downloaded artifacts:

## CppCheck 2.10 Summary

| error | warning | style | performance | portability | information |
| --- | --- | --- | --- | --- | --- |
| 0 | 0 | 4 | 0 | 0 | 0 |

| severity | location | error id | issue |
| --- | --- | --- | --- |
| style | source/fsw/generic-vxworks-rtp/parg/parg.c:33 | constParameter | Parameter 'argv' can be declared as const array |
| style | source/fsw/generic-vxworks-rtp/src/cfe_psp_start.c:242 | unreadVariable | Variable 'taskname[16-1]' is assigned a value that is never used. |
| style | source/fsw/modules/linux_sysmon/linux_sysmon.c:70 | unusedStructMember | struct member 'linux_sysmon_cpuload_state::num_samples' is never used. |
| style | source/fsw/modules/linux_sysmon/linux_sysmon.c:71 | unusedStructMember | struct member 'linux_sysmon_cpuload_state::last_sample_time' is never used. |

**4 error(s) reported**

These 4 are the same errors reported here.

@Cameron-Sykes
Cameron-Sykes self-requested a review July 23, 2026 14:10

@Cameron-Sykes Cameron-Sykes left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hereby declare this PR to be completed to a satisfactory level. It shall be merged into dev upon the clearing of the pipeline issues by an outside authority

@elizabash
elizabash merged commit 04097ba into nasa:dev Jul 27, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PSP RTEMS variable typo: OVERRIDE_TODIMPL_H

3 participants