Skip to content

Fix #497, Remove Dead Functions - #498

Merged
arielswalker merged 1 commit into
nasa:devfrom
arielswalker:fix-497-remove-dead-functions
Aug 6, 2026
Merged

Fix #497, Remove Dead Functions#498
arielswalker merged 1 commit into
nasa:devfrom
arielswalker:fix-497-remove-dead-functions

Conversation

@arielswalker

@arielswalker arielswalker commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fixes #497

Testing performed
Ran the native_std commands which includes prep, install, runtest, and lcov. Compared these lcov results against the unchanged cFS bundle and found no changes. Ran the old build commands with unit tests enabled to ensure that the internal static code analysis tool no longer flags these functions. Also ran the bundle with -Wunused flags which only flagged unrelated macros.

Expected behavior changes
Removes four dead functions

  1. UT_Set_Exception_StorageReadWrite
  2. UT_Get_Exception_Size
  3. UT_Get_Exception_TotalStorageSize
  4. UT_Set_Exception_StoragePtr

System(s) tested on
RedHat, cFS dev

Additional context
Lcov bundle results using native_std:

Overall coverage rate:
  lines......: 99.2% (30304 of 30537 lines)
  functions..: 99.2% (2428 of 2447 functions)
  branches...: no data found

Lcov bundle results using the old build commands:

Overall coverage rate:
  lines......: 99.2% (30167 of 30396 lines)
  functions..: 99.2% (2417 of 2436 functions)
  branches...: 98.7% (12931 of 13095 branches)

Static analysis workflow errors are pre-existing and documented in this issue

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Walker, MCSG TECH.

@arielswalker arielswalker self-assigned this Jul 30, 2026

@chillfig chillfig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@arielswalker
arielswalker merged commit f1feb7f into nasa:dev Aug 6, 2026
10 of 12 checks passed
@arielswalker
arielswalker deleted the fix-497-remove-dead-functions branch August 6, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Dead Functions

3 participants