Skip to content

Comments

Minimize stack trace needed#6

Merged
nasser merged 1 commit intonasser:masterfrom
amasad:master
Jan 17, 2013
Merged

Minimize stack trace needed#6
nasser merged 1 commit intonasser:masterfrom
amasad:master

Conversation

@amasad
Copy link
Contributor

@amasad amasad commented Jan 17, 2013

Quick hack. Makes the examples run in safari.

nasser added a commit that referenced this pull request Jan 17, 2013
Minimize stack trace needed
@nasser nasser merged commit 2db6065 into nasser:master Jan 17, 2013
@nasser
Copy link
Owner

nasser commented Jan 17, 2013

That was amazing! How does that work? I can't see why it would be different from the current implementation.

You are some kind of wizard...

@amasad
Copy link
Contributor Author

amasad commented Jan 17, 2013

haha, it's just the array helpers map etc. Adds more functions calls to the stack and are generally slower.

@nasser
Copy link
Owner

nasser commented Jan 17, 2013

Wow. So simple...

@amasad
Copy link
Contributor Author

amasad commented Jan 17, 2013

Yeah, but still it's just a temporary solution. Eventually it has to be trampolined or done asynchronously (setTimeout).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants