-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev to main #518
Merged
Merged
dev to main #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the filter_subject but allows a consumer to filter multiple subjects in a stream. To set, specify filter_subjects instead of filter_subject or if using consumer options builder filterSubject() can be called multiple times. [CHANGE] filter_subject (and filter_subjects) can be updated, the server removed this restriction
…f the filter_subject but allows a consumer to filter multiple subjects in a stream. To set, specify filter_subjects instead of filter_subject or if using consumer options builder filterSubject() can be called multiple times. [CHANGE] filter_subject (and filter_subjects) can be updated, the server removed this restriction
[FEAT] multiple consumer filters
…s we succeed when updating the metadata
…icators - this means that now, setting up user/pass, token and a creds authenticator, etc is legal - previously such combinations were rejected.
[FIX] add support `previousRevision` in ObjectStorePutOps
[FEAT] multiple authenticators
FIX] ServiceMsgImpl was missing access to headers or reply subject
…oredMsg, DirectMsg this allows clients to decode payloads easier while still requiring accountability on the client (as decoding can fail)
[FEAT] Added json()/string() utilities to Msg and other variants
…ch would yield NaN - this is degenerate, but at least it doesn't have an unexpected code value
# Conflicts: # src/deno_transport.ts
[FIX] malformed status created a NaN code
[FIX] added a check on createInbox() to reject prefixes that contain wildcards
[FEAT] [JS] consumer/stream metadata
# Conflicts: # src/deno_transport.ts # tests/kv_test.ts
…ovided by the server (time() returns a Date object which will have lower precision) [FIX] fixed StreamInfo.created to be a `string` (was marked as Nanos), StreamState@first_ts to be a string. Fixes https://github.com/nats-io/nats.js/issues/556
timestamp types were incorrectly tagged as Nanos rather than strings
# Conflicts: # src/deno_transport.ts
[FEAT] srv metadata
…eam tooling easier
[FEAT] [SRV] include schema metadata on ServiceSchema to make downstream tooling easier
… a transform to incoming messages before anything else. [FEAT] [JS] `StreamSource` configurations can specify a `SubjectTransformConfig` to map a source and destination pattern.
[FEAT] subject transforms
[FIX] [JS] consumer deleted error was recently added, but was not interpreted as a terminal error - this enables the client to detect this on pull consumers - note that for push consumers the consumer deleted error is not raised, so heartbeats are the only reliable mechanism to detect when things go wrong.
* [FEAT] JS Simplification
* [FIX] accounting for pull request messages was happening when the iterator executed, creating additional pulls on the next message to be processed. [FIX] tagged consumers api as beta, deprecated legacy subscribes/fetch/etc. * making test pass * PR comments
…bject that allows for easy access to alternates, best (best mirror as per nats-server), get an existing consumer (or ordered consumer) associated with the stream, and to manually retrieve a message. Some of this functionality is already available via JSM, this simply provides more convenient access. (#508)
[FIX] [SRV] `metadata` not included in `stats`, `schema` or `ping` responses [FIX] [SRV] cross-client test to print a context when generating an error [CHANGE] [SRV] removed `apiURL` config option and `api_url` - use `metadata` on the service [CHANGE] [SRV] removed schema reporting, configuration, and related types - use `metadata` on the endpoint [CHANGE] [SRV] removed endpoint configuration from initial service configuration, use `addEndpoint()` [DOC] updated the doc and examples for service
… using filtered_subjects (#517)
Jarema
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges into main JS Simplification and other client changes