Skip to content

fix: fetchGDB when WHERE is NULL#467

Merged
brownag merged 5 commits into
masterfrom
fix-466
May 6, 2026
Merged

fix: fetchGDB when WHERE is NULL#467
brownag merged 5 commits into
masterfrom
fix-466

Conversation

@brownag

@brownag brownag commented Apr 29, 2026

Copy link
Copy Markdown
Member
  • or otherwise not legend/mapunit level constraint

Fix for #466

Also, fixes warning due to primary key duplication with fid_column_name on a non-spatial table. This is a super annoying behavior, and probably we need a wrapper function around sf::read_sf() instead of all the ad hoc NULLing of keys that needs to be done to get the FGDB result to match GPKG.

Also, adds tests to close long-standing issue #398

 - or not legend/mapunit level constraint
@brownag brownag requested a review from smroecker April 29, 2026 21:23
@brownag brownag marked this pull request as draft May 1, 2026 00:07
@brownag brownag marked this pull request as ready for review May 1, 2026 00:11
@brownag brownag merged commit dd240c4 into master May 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failure to fetchGDB Add unit tests for fetchGDB() SSURGO File Geodatabase related functions

1 participant