fix: reload page on SignalR manual_selection transition (closes #172) - #188
Conversation
|
Reviewed and approved. The fix reloads the page when the SignalR live-update path detects a transition to manual_selection while submitManualSelection() is undefined, so the server re-renders the track checkboxes, select-all checkbox, and the function. The manualSelectionSubmitted guard correctly avoids reloading after a user submission (issue #182). Build passes with 0 warnings/errors; all 496 tests pass. Ready for merge. Note: this overlaps with PR #189 (issue #168) which adds a similar reload on the transition INTO manual_selection — both are valid; if merged together the guards are complementary (reload is idempotent). |
21b7a4d to
9eb87db
Compare
|
Rebased onto master (which now includes PR #189 / issue #168). The two reload guards are complementary: #189's transition guard ( |
Automated Fix
Fixes #172
Changes
When the SignalR live-update handler detects the job has transitioned to
manual_selection(ManualSelectionStarted) but thesubmitManualSelection()function is not defined (meaning the page was initially loaded in a different state), trigger a full page reload. This ensures the server re-renders the track selection checkboxes, the select-all checkbox, and thesubmitManualSelection()function — all of which are only emitted in the Razor template when the page initially renders inManualSelectionStarted.Without this fix, clicking the "Continue Rip" button injected by SignalR causes a
ReferenceErrorbecausesubmitManualSelectionwas never defined, and the track checkboxes are also missing from the DOM.Testing