Skip to content

fix: reload JobDetails on entering manual selection to show track titles (closes #168) - #189

Merged
negativeeddy merged 1 commit into
masterfrom
fix/issue-#168
Sep 6, 2026
Merged

fix: reload JobDetails on entering manual selection to show track titles (closes #168)#189
negativeeddy merged 1 commit into
masterfrom
fix/issue-#168

Conversation

@negativeeddy

Copy link
Copy Markdown
Owner

Automated Fix

Fixes #168

Changes

When a job pauses in manual selection mode after the identification phase, the JobDetail page now reloads on the transition into manual_selection status. This re-renders the server-side track table, which already displays the identified episode titles (populated by the DiscDb track mapping during identification).

The reload is guarded to fire only on the transition into manual selection — while already in the state (e.g. after submitting a selection, issue #182) the status doesn't change, so no reload occurs and the optimistic-removal flow is preserved.

Testing

  • All existing tests pass (81 WebUi + 303 Core)
  • Added JobDetail_ManualSelectionState_RendersReloadOnTransitionScript regression test verifying:
    • The page seeds lastStatus with the server-rendered status
    • The reload guard is present in the rendered script
    • Identified episode titles render in the track table

@negativeeddy

Copy link
Copy Markdown
Owner Author

Reviewed and approved. The fix seeds lastStatus from the server-rendered status (via ToDbString(), which maps ManualSelectionStarted to 'manual_selection' — matching the SignalR status string) and reloads the page only on the transition INTO manual_selection, so the server re-renders the track table with identified episode titles. The guard correctly avoids a reload loop when the page renders already in that state, and preserves the issue #182 submit flow. The new regression test verifies the seeding, the guard, and episode-title rendering. Build passes with 0 warnings/errors; all 497 tests pass. Ready for merge.

Note: this overlaps with PR #188 (issue #172) which adds a similar reload guard for the live-update path — both are valid; if merged together the guards are complementary (reload is idempotent).

@negativeeddy
negativeeddy merged commit 7fa3d35 into master Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JobDetails - Manual mode doesnt show episode titles

1 participant