fix: reload JobDetails on entering manual selection to show track titles (closes #168) - #189
Conversation
|
Reviewed and approved. The fix seeds lastStatus from the server-rendered status (via ToDbString(), which maps ManualSelectionStarted to 'manual_selection' — matching the SignalR status string) and reloads the page only on the transition INTO manual_selection, so the server re-renders the track table with identified episode titles. The guard correctly avoids a reload loop when the page renders already in that state, and preserves the issue #182 submit flow. The new regression test verifies the seeding, the guard, and episode-title rendering. Build passes with 0 warnings/errors; all 497 tests pass. Ready for merge. Note: this overlaps with PR #188 (issue #172) which adds a similar reload guard for the live-update path — both are valid; if merged together the guards are complementary (reload is idempotent). |
Automated Fix
Fixes #168
Changes
When a job pauses in manual selection mode after the identification phase, the JobDetail page now reloads on the transition into
manual_selectionstatus. This re-renders the server-side track table, which already displays the identified episode titles (populated by the DiscDb track mapping during identification).The reload is guarded to fire only on the transition into manual selection — while already in the state (e.g. after submitting a selection, issue #182) the status doesn't change, so no reload occurs and the optimistic-removal flow is preserved.
Testing
JobDetail_ManualSelectionState_RendersReloadOnTransitionScriptregression test verifying:lastStatuswith the server-rendered status