Release v0.2.4: funder chips, profile completeness gate - #234
Merged
Conversation
Docs: promotion is a release PR, not a direct push
Fix empty funder chips on dataset pages
…file-completeness
Docs: Closes #N does not fire on staging PRs
…ness Nudge incomplete profiles, gate upload on city and country
Handoff for v0.2.4
Deploying nemar-website with
|
| Latest commit: |
0e7f3a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10876ca1.nemar-website.pages.dev |
| Branch Preview URL: | https://staging.nemar-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes staging to production at v0.2.4.
Changes since v0.2.3
#204 — empty funder chips on dataset pages (PR #230).
Funding.funderneverexisted; the API sends
funder_name, so every dataset page rendered blank funderspans. Renames the field, adds the two the type omitted (
award_uri,funder_identifier_type), and addsdisplayableFunding()which trims and dropsnameless entries so a null cannot recreate the blank chip. Review surveyed the full
catalog to check that dropping nameless entries hides nothing: 1080 funding entries
across 408 datasets, all carrying
funder_name, none carryingfunder, none withaward data and no funder name.
#226 — profile completeness (PR #231). Dismissible dashboard nudge, plus a
server-side city/country gate on
/uploadthat withholds the form rather than hidingit.
src/lib/profile.tsis the single definition of "complete" shared by allsurfaces. GitHub handle stays a publish-time requirement, not an upload one, per
#129.
Docs (#232, #233).
Closes #Ndoes not fire on PRs merged tostaging(GitHubhonours closing keywords only on the default branch), plus the v0.2.4 handoff.
Release verification
Verified on test.nemar.org running this exact commit (0.2.4+0e7f3a6), signed in with
a real backend session:
/uploadrenders the gate with zerodata-upload-formin the HTMLDev-auth containment checked explicitly, since this release adds a
@nemar.blankdev persona toauth-dev.ts: a production build contains zerooccurrences of
nemar.blank,buildDevUser, or the persona strings. Theimport.meta.env.DEVbranch is dead-code-eliminated andbuildDevUserhas no othercall site.
No JS crash path on the gated upload page: every element dereference in
upload.astro's script sits behind an early-return null guard, the only top-levelwiring is optional-chained (
form?.,precheckReset?.), andUploadDropzone'sscript is wrapped in
if (zone && input), so thenemar:files-droppedevent cannever be dispatched when the form is withheld.
Risk
Low. Nothing here touches host routing, canonical origins, middleware, or auth
proxying, so the staging single-host limitation (website#212) does not leave a gap
for this release. The one behavioral change for existing users is the upload gate,
which affects only accounts missing city or country.