Skip to content

fix(RpcClient): throw on non-success HTTP before parsing JSON - #1101

Merged
shargon merged 2 commits into
neo-project:master-n3from
cschuchardt88:fix/rpcclient-http-status
Aug 31, 2026
Merged

fix(RpcClient): throw on non-success HTTP before parsing JSON#1101
shargon merged 2 commits into
neo-project:master-n3from
cschuchardt88:fix/rpcclient-http-status

Conversation

@cschuchardt88

Copy link
Copy Markdown
Member

Send/SendAsync parsed the body even when the HTTP status was 4xx/5xx. Proxy HTML and gateway errors became JSON parse failures instead of HttpRequestException.

JSON-RPC errors still arrive as HTTP 200 with an error object and are unchanged.

Independent of other PRs. RpcClient only; not consensus-critical.

Send/SendAsync parsed the body even when the HTTP status was 4xx/5xx. Proxy HTML and gateway errors became JSON parse failures instead of HttpRequestException.
@github-actions github-actions Bot added the N3 label Aug 29, 2026
@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 51.42%. Comparing base (2e491a2) to head (afbaa96).

Files with missing lines Patch % Lines
plugins/RpcClient/RpcClient.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           master-n3    #1101      +/-   ##
=============================================
- Coverage      51.42%   51.42%   -0.01%     
=============================================
  Files            284      284              
  Lines          16677    16679       +2     
  Branches        2143     2143              
=============================================
+ Hits            8576     8577       +1     
- Misses          7527     7528       +1     
  Partials         574      574              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shargon
shargon merged commit 404112b into neo-project:master-n3 Aug 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants