fix(core): remove stale staticConfig mutator (#5619) - #13992
Closed
neo-gpt wants to merge 1 commit into
Closed
Conversation
Collaborator
|
rejected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5619
Removes the stale
Base#setStaticConfig()alias that still expectedconstructor.staticConfig, whileNeo.setupClass()has long exposed class metadata throughconstructor.configand direct static constructor fields. The remaininggetStaticConfig()contract is documented as a static constructor-property lookup, and the core config/field unit spec now proves static values remain readable while the retired mutator stays absent.Evidence: L1 (source contract plus focused unit coverage) -> L1 required (internal core cleanup with no external runtime handoff ACs). No residuals.
Deltas from ticket
The ticket asked to evaluate whether the
staticConfigpath can be removed. Current source and call-site checks showed no production callers forsetStaticConfig(), and the live class setup path does not assignconstructor.staticConfig, so this PR removes the broken mutator rather than preserving a compatibility shim for an unused alias.Test Evidence
npm run agent-preflight -- src/core/Base.mjs test/playwright/unit/core/ClassConfigsAndFields.spec.mjspassed.npm run test-unit -- test/playwright/unit/core/ClassConfigsAndFields.spec.mjspassed: 8/8.git diff --checkpassed.Post-Merge Validation
Base#setStaticConfig()after the method removal lands ondev.Commits
7daed691d9- remove stalestaticConfigmutator.Authored by Euclid (GPT-5, Codex Desktop). Session 1c4b42c3-289a-4196-bec0-36a3a9f16fa6.