fix(ai): append LMS embedding SEP from metadata (#14009) - #14014
Merged
Conversation
neo-gpt
force-pushed
the
codex/14009-lmstudio-sep-warning
branch
from
June 25, 2026 15:48
8a30d9b to
63cccb8
Compare
neo-gpt
force-pushed
the
codex/14009-lmstudio-sep-warning
branch
from
June 25, 2026 16:01
63cccb8 to
64274a2
Compare
tobiu
approved these changes
Jun 25, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #14009
Related: #13999
Fixes the actual LM Studio warning path.
TextEmbeddingServicenow preserves LMS loaded-model metadata fromlms ps --jsonand, only when the active OpenAI-compatible endpoint is the orchestrator-owned LMS lane and the resident embedding model metadata identifies GGUF/Qwen3, appends<|im_end|>to the outbound embedding request strings. Stored Memory Core / KB text is not mutated, and generic OpenAI-compatible or Ollama-compatible endpoints do not receive the LMS/Qwen suffix.Evidence: L2 unit/preflight evidence covers the request boundary; live local LMS metadata was also checked and shows
format: gguf,architecture: qwen3, andembeddingModel: text-embedding-qwen3-embedding-8bon the configured LMS port. I did not add another live embedding request while LMS reported queued work.Deltas from ticket
The first version of this PR was wrong: it documented or tested around the warning instead of satisfying LMS. This revision implements the ticket goal directly by making Neo send strings whose final token resolves to the LMS-required Qwen3 separator on the LMS metadata path. The earlier cloud DeploymentCookbook note is gone; cloud deployments do not use macOS
lms.Test Evidence
npm run test-unit -- test/playwright/unit/ai/services/memory-core/TextEmbeddingService.retry.spec.mjs test/playwright/unit/ai/scripts/runners/runSandman.spec.mjs— 85 passednpm run agent-preflight -- ai/services/graph/providerReadinessHelper.mjs ai/services/memory-core/TextEmbeddingService.mjs test/playwright/unit/ai/services/memory-core/TextEmbeddingService.retry.spec.mjs test/playwright/unit/ai/scripts/runners/runSandman.spec.mjsgit diff --checkhttp://127.0.0.1:1234,orchestrator.lms.enabled=true, LMS port1234;lms ps --jsonexposesformat: gguf,architecture: qwen3.Post-Merge Validation
tokenizer.ggml.add_eos_token should be set to true.Commits
64274a27d2—fix(ai): append LMS embedding SEP from metadata (#14009)Authored by Euclid (GPT-5 Codex, Codex Desktop). Session 9280140f-8b54-4462-9342-49cca7e226f4.