Skip to content

Add Windows wheels with netft-cpp 0.3.0 - #2

Merged
han-xudong merged 1 commit into
mainfrom
feat/windows-wheels-netft-cpp-0.3
Jul 29, 2026
Merged

Add Windows wheels with netft-cpp 0.3.0#2
han-xudong merged 1 commit into
mainfrom
feat/windows-wheels-netft-cpp-0.3

Conversation

@han-xudong

@han-xudong han-xudong commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

  • update the pinned native core to netft-cpp 0.3.0
  • publish self-contained CPython 3.10-3.14 Windows x86-64 wheels
  • add pinned static HTTP-only curl production and PE dependency validation on Windows

Validation

  • pixi run check
  • Release native CMake build and CTest
  • CMake 3.16 core build
  • local wheel and sdist build, metadata, and structure validation

Summary by CodeRabbit

  • New Features
    • Added publishing and validation coverage for self-contained 64-bit Windows wheels for CPython 3.10–3.14.
    • Windows wheel checks now verify dependency requirements and reject dynamically linked curl libraries.
  • Documentation
    • Updated supported-platform guidance to reflect the tested native core and clarify Windows + non-support of PyPy/asyncio for the 2.x package.
  • Release
    • Released version 2.1.0, updating the pinned native core and Windows packaging to use a static, HTTP-only curl dependency, with platform-specific artifact validation.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@han-xudong, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 978909eb-9577-451c-8784-a52ec90461ba

📥 Commits

Reviewing files that changed from the base of the PR and between 3446329 and 52eb7a0.

📒 Files selected for processing (27)
  • .github/workflows/ci.yml
  • .github/workflows/codeql.yml
  • .github/workflows/coverage.yml
  • .github/workflows/release.yml
  • .github/workflows/wheels.yml
  • CHANGELOG.md
  • CMakeLists.txt
  • README.md
  • core/CMakeLists.txt
  • core/SNAPSHOT.sha256
  • core/UPSTREAM
  • core/src/detail/client_impl.cpp
  • core/src/detail/client_impl.hpp
  • core/src/detail/posix_transport.hpp
  • core/src/detail/udp_transport.hpp
  • core/src/detail/udp_transport_posix.cpp
  • core/src/detail/udp_transport_windows.cpp
  • core/src/discovery.cpp
  • pixi.toml
  • pyproject.toml
  • tests/artifact/test_wheel.py
  • tests/python/test_import.py
  • tests/quality/test_wheel_configuration.py
  • tests/release/test_metadata.py
  • tools/build_windows_curl.ps1
  • tools/check_release_artifacts.py
  • tools/check_wheel.py
📝 Walkthrough

Walkthrough

The project updates its native core to 0.3.0, adds Windows UDP transport and static curl wheel support, validates Windows wheels through CI and PE inspection, and releases version 2.1.0 with Windows artifacts included in the platform inventory.

Changes

Windows wheel release support

Layer / File(s) Summary
Cross-platform UDP transport
core/CMakeLists.txt, core/src/detail/*, core/SNAPSHOT.sha256, core/UPSTREAM
The native core switches to UdpTransport, adds POSIX and WinSock implementations, introduces shutdown-aware polling, and makes CLI construction conditional.
Windows native dependency packaging
CMakeLists.txt, pyproject.toml, tools/build_windows_curl.ps1, tools/check_wheel.py, tests/quality/test_wheel_configuration.py
Windows builds configure required system libraries, build pinned static curl, and reject dynamic libcurl imports while accepting .pyd extensions.
Windows wheel CI and release assembly
.github/workflows/wheels.yml, .github/workflows/release.yml, tools/check_release_artifacts.py, tests/release/test_metadata.py, tests/quality/test_wheel_configuration.py
PR, non-PR, and release workflows build, validate, upload, and assemble Windows wheels; artifact inventory validation recognizes win_amd64.
Release metadata and validation
CHANGELOG.md, README.md, pixi.toml, tests/artifact/test_wheel.py, tests/python/test_import.py, tests/quality/test_wheel_configuration.py, tests/release/test_metadata.py, .github/workflows/ci.yml
Version references, platform documentation, artifact fixtures, release expectations, CI metadata checks, and workflow assertions are updated for 2.1.0 and Windows support.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant GitHubActions
  participant Cibuildwheel
  participant WheelValidator
  participant ArtifactStore
  GitHubActions->>Cibuildwheel: build AMD64 Windows wheels
  Cibuildwheel->>WheelValidator: run check_wheel.py --self-contained
  WheelValidator-->>GitHubActions: return validation result
  GitHubActions->>ArtifactStore: upload validated wheel artifacts
  ArtifactStore-->>GitHubActions: supply artifacts to assemble
Loading

Possibly related PRs

  • netft/pyNetFT#1: Introduces the original transport implementation replaced by this PR’s UdpTransport.
  • netft/pyNetFT#9: Changes wheel platform normalization and release artifact inventory validation.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 2.56% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding Windows wheels and updating the native core to netft-cpp 0.3.0.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/windows-wheels-netft-cpp-0.3

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/wheels.yml:
- Line 112: Pin every actions/checkout usage in .github/workflows/wheels.yml at
lines 20, 42, 81, 112, 150, 188, and 218 to a specific immutable commit SHA
instead of the mutable v7 tag.

In `@tools/check_wheel.py`:
- Around line 57-64: Update validate_windows_dependencies to validate every
imported DLL against an explicit allowlist of permitted Windows and Python
runtime DLLs, rather than only matching curl names. Preserve case-insensitive
matching, and raise WheelValidationError listing any dependency not in the
allowlist.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: df03ab11-7126-4b99-9bd2-28e0606b8a2c

📥 Commits

Reviewing files that changed from the base of the PR and between 1ecc3fd and c5af583.

📒 Files selected for processing (24)
  • .github/workflows/release.yml
  • .github/workflows/wheels.yml
  • CHANGELOG.md
  • CMakeLists.txt
  • README.md
  • core/CMakeLists.txt
  • core/SNAPSHOT.sha256
  • core/UPSTREAM
  • core/src/detail/client_impl.cpp
  • core/src/detail/client_impl.hpp
  • core/src/detail/posix_transport.hpp
  • core/src/detail/udp_transport.hpp
  • core/src/detail/udp_transport_posix.cpp
  • core/src/detail/udp_transport_windows.cpp
  • core/src/discovery.cpp
  • pixi.toml
  • pyproject.toml
  • tests/artifact/test_wheel.py
  • tests/python/test_import.py
  • tests/quality/test_wheel_configuration.py
  • tests/release/test_metadata.py
  • tools/build_windows_curl.ps1
  • tools/check_release_artifacts.py
  • tools/check_wheel.py
💤 Files with no reviewable changes (1)
  • core/src/detail/posix_transport.hpp

Comment thread .github/workflows/wheels.yml Outdated
Comment thread tools/check_wheel.py Outdated
@han-xudong
han-xudong force-pushed the feat/windows-wheels-netft-cpp-0.3 branch 4 times, most recently from 5f59e1e to f507829 Compare July 29, 2026 10:58
@han-xudong
han-xudong force-pushed the feat/windows-wheels-netft-cpp-0.3 branch from f507829 to 52eb7a0 Compare July 29, 2026 11:12
@han-xudong
han-xudong merged commit c7249d9 into main Jul 29, 2026
27 checks passed
@han-xudong
han-xudong deleted the feat/windows-wheels-netft-cpp-0.3 branch July 29, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant