Skip to content

chore: migrate docs to es modules#4143

Merged
kodiakhq[bot] merged 12 commits into
mainfrom
chore/migrate-docs-esm
Feb 3, 2022
Merged

chore: migrate docs to es modules#4143
kodiakhq[bot] merged 12 commits into
mainfrom
chore/migrate-docs-esm

Conversation

@lukasholzer
Copy link
Copy Markdown
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Part of the incremental migration to esmodules migrate the docs


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lukasholzer lukasholzer added the type: chore work needed to keep the product and development running smoothly label Jan 28, 2022
@lukasholzer lukasholzer requested a review from erezrokah January 28, 2022 12:21
@lukasholzer lukasholzer requested a review from a team as a code owner January 28, 2022 12:21
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 28, 2022

📊 Benchmark results

Comparing with 3d40fe1

Package size: 361 MB

⬇️ 0.00% decrease vs. 3d40fe1

^  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  361 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

erezrokah
erezrokah previously approved these changes Jan 28, 2022
@lukasholzer
Copy link
Copy Markdown
Contributor Author

@erezrokah the deploy of the docs is failing as it executes the .js file. But in the repository this is not configured anymore:

CleanShot 2022-01-28 at 14 01 19

Is there a different place where this is configured? or is netlify using the main branch for the command?

@erezrokah
Copy link
Copy Markdown
Contributor

erezrokah commented Jan 28, 2022

@erezrokah the deploy of the docs is failing as it executes the .js file. But in the repository this is not configured anymore:

We cd into the site directory so this

"build:docs": "node scripts/docs.js",
should be updated too (see my latest commit)

@lukasholzer
Copy link
Copy Markdown
Contributor Author

@erezrokah the deploy of the docs is failing as it executes the .js file. But in the repository this is not configured anymore:

We cd into the site directory so this

"build:docs": "node scripts/docs.js",

should be updated too (see my latest commit)

oh was completely over looking this detail always was searching for the full path 🤦

@lukasholzer lukasholzer requested a review from erezrokah January 28, 2022 16:24
Copy link
Copy Markdown
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lukasholzer
Copy link
Copy Markdown
Contributor Author

depends on #4143

@lukasholzer lukasholzer added the automerge Add to Kodiak auto merge queue label Feb 3, 2022
@kodiakhq kodiakhq Bot merged commit cc2c6dd into main Feb 3, 2022
@kodiakhq kodiakhq Bot deleted the chore/migrate-docs-esm branch February 3, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Add to Kodiak auto merge queue type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants