Skip to content

fix: stop publishing source maps - #8468

Merged
serhalp merged 2 commits into
mainfrom
fix/dont-publish-source-maps
Sep 4, 2026
Merged

fix: stop publishing source maps#8468
serhalp merged 2 commits into
mainfrom
fix/dont-publish-source-maps

Conversation

@serhalp

@serhalp serhalp commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

534 of this npm package's 1128 files are source map files, which aren't useful to users.

This PR stops publishing them, dropping 184 KB from the download size and 0.92 MB from the size on disk:

before after
tarball 480 KB 296 KB −38%
unpacked 2.06 MB 1.14 MB −45%
files 1128 595 −47%

See also https://e18e.dev/blog/source-maps-or-not.html.

Supersedes #8464.

@serhalp
serhalp requested a review from a team as a code owner September 3, 2026 21:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T14:29:31.025817Z 3033f0b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 616f9619-3eeb-45d3-b701-e222e40eb032

📥 Commits

Reviewing files that changed from the base of the PR and between 0abbad1 and 3033f0b.

📒 Files selected for processing (1)
  • package.json
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • netlify/blueprints (manual)

Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated package publishing configuration so released packages include the built distribution files needed for installation and use.
    • Source map files are excluded from published packages, resulting in a cleaner package contents and smaller distribution footprint.
    • No changes were made to the package’s exported functionality or public interfaces.

Walkthrough

The package files configuration now publishes the dist directory while excluding dist/**/*.map source map files.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3033f

The package will no longer publish source maps while retaining compiled distribution files. No merge-blocking impact is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains that the pull request stops publishing source map files and reduces package size. It matches the changeset.
Title check ✅ Passed The title clearly and concisely describes the main change: stopping publication of source map files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dont-publish-source-maps

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

📊 Benchmark results

Comparing with b4e000f

  • Dependency count: 1,069 (no change)
  • Package size: 424 MB ⬇️ 0.00% decrease vs. b4e000f
  • Number of ts-expect-error directives: 346 (no change)

@pkg-pr-new

pkg-pr-new Bot commented Sep 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/netlify-cli@8468

commit: 3033f0b

@serhalp
serhalp requested a review from jherr September 3, 2026 21:57
@serhalp
serhalp enabled auto-merge (squash) September 4, 2026 13:39
@serhalp
serhalp merged commit 3282dab into main Sep 4, 2026
37 checks passed
@serhalp
serhalp deleted the fix/dont-publish-source-maps branch September 4, 2026 14:36
serhalp pushed a commit that referenced this pull request Sep 4, 2026
🤖 I have created a release *beep* *boop*
---


## [27.5.0](v27.4.3...v27.5.0)
(2026-09-04)


### Features

* **clone:** support Netlify managed git service
([#8437](#8437))
([4476e10](4476e10))
* **logs:** add --deploy-id flag to target a specific deploy
([28e44be](28e44be))


### Bug Fixes

* **deps:** update dependency chalk to v6
([#8470](#8470))
([9ebe398](9ebe398))
* **deps:** update dependency comment-json to v5
([#8471](#8471))
([f458d83](f458d83))
* **logs:** auto-select the latest finished deploy, including failures
([b312e2d](b312e2d))
* **logs:** close the deploy stream when replaying a finished deploy
([8b84c92](8b84c92))
* **logs:** fetch historical deploy logs over websocket
([783c3d9](783c3d9))
* **logs:** keep the deploy stream resilient to failed state checks
([d874293](d874293))
* **logs:** stream the targeted deploy in --follow
([d04b659](d04b659))
* stop publishing source maps
([#8468](#8468))
([3282dab](3282dab))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants