Close SocketChannel upon exceptions to avoid leaking#10110
Merged
Conversation
This fixes netty#10109 by correctly closing the channel upon exceptions.
blindpirate
force-pushed
the
fix-file-handle-leaking
branch
from
36d6f42 to
8033e6a
Compare
|
Can one of the admins verify this patch? |
Member
|
@blindpirate please sign our ICLA and let me know once done: |
Contributor
Author
|
Done. @normanmaurer |
Member
|
@netty-bot test this please |
normanmaurer
requested changes
Mar 16, 2020
Member
|
@blindpirate I just pushed a commit with the changes and a test case... PTAL |
blindpirate
commented
Mar 16, 2020
Contributor
Author
blindpirate
left a comment
blindpirate
left a comment
There was a problem hiding this comment.
LGTM. Thanks, I'm not familiar with the test, but you did it great.
Member
|
@netty-bot test this please |
Contributor
Author
|
@normanmaurer out of curiosity, is "test this please" is a fixed command for @netty-bot ? Can I ask him to test by "can you please test this change"? Is that bot opensource? |
Member
|
@blindpirate it can only be done by admins so we ensure no-one DDOS it. It is a Jenkins plugin. |
Contributor
Author
|
Good to know, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #10109
by correctly closing the channel upon exceptions.
Fixes #10109