Close the file in case of an IOException in AbstractMemoryHttpData.renameTo.#10163
Merged
normanmaurer merged 2 commits intonetty:4.1from Apr 6, 2020
Merged
Close the file in case of an IOException in AbstractMemoryHttpData.renameTo.#10163normanmaurer merged 2 commits intonetty:4.1from
normanmaurer merged 2 commits intonetty:4.1from
Conversation
|
Can one of the admins verify this patch? |
Member
|
@netty-bot test this please |
…at we can read all file data anyway.
Member
|
@netty-bot test this please |
Member
|
@seedeed thanks a lot |
normanmaurer
pushed a commit
that referenced
this pull request
Apr 6, 2020
…nameTo. (#10163) Motivation: An `IOException` may be thrown from `FileChannel.write` or `FileChannel.force`, and cause the fd leak. Modification: Close the file in a finally block. Result: Avoid fd leak.
ihanyong
pushed a commit
to ihanyong/netty
that referenced
this pull request
Jul 31, 2020
…nameTo. (netty#10163) Motivation: An `IOException` may be thrown from `FileChannel.write` or `FileChannel.force`, and cause the fd leak. Modification: Close the file in a finally block. Result: Avoid fd leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
An
IOExceptionmay be thrown fromFileChannel.writeorFileChannel.force, and cause the fd leak.Modification:
Close the file in a finally block.
Result:
Avoid fd leak.