[Issue-10320] More values other than chunked defined in Transfer-Encoding header leads to decode failure#10321
Merged
Conversation
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
normanmaurer
requested changes
May 27, 2020
gaol
force-pushed
the
check_chunked_request_header
branch
from
399a391 to
acb2313
Compare
Contributor
Author
|
@normanmaurer Done by addressing the above comments, thanks :) |
gaol
force-pushed
the
check_chunked_request_header
branch
from
acb2313 to
7e98c1a
Compare
Contributor
Author
|
@idelpivnitskiy After trying to use the full gzipped http request and checked the desired decoded request content, I found it did not decode the gzip content if we have |
normanmaurer
requested changes
May 29, 2020
idelpivnitskiy
approved these changes
May 29, 2020
Member
idelpivnitskiy
left a comment
idelpivnitskiy
left a comment
There was a problem hiding this comment.
LGTM after Norman's comment is addressed
…ding header leads to decode failure
gaol
force-pushed
the
check_chunked_request_header
branch
from
7e98c1a to
7cadd57
Compare
Contributor
Author
|
Updated PR to address review comments. Thanks :) |
Member
|
@netty-bot test this please |
normanmaurer
approved these changes
Jun 2, 2020
Member
|
@gaol thanks a lot |
normanmaurer
pushed a commit
that referenced
this pull request
Jun 2, 2020
…ads to decode failure (#10321) Motivation: `containsValue()` will check if there are multiple values defined in the specific header name, we need to use this method instead of `contains()` for the `Transfer-Encoding` header to cover the case that multiple values defined, like: `Transfer-Encoding: gzip, chunked` Modification: Change from `contains()` to `containsValue()` in `HttpUtil.isTransferEncodingChunked()` method. Result: Fixes #10320
Kvicii
pushed a commit
to Kvicii/netty
that referenced
this pull request
Jun 6, 2020
* '4.1' of github.com:netty/netty: Motivation: (netty#10326) Fix netty#10261 stomp can be chunked, so implement StompWebSocketFrameEncoder (netty#10274) Update test to directly check for SslHandshakeTimeoutException (netty#10339) Fix possible StackOverflowError when try to resolve authorative names… (netty#10337) Fix a test case problem: testSwallowedReadComplete(...) may fail with an AssertionError sometimes. (netty#10313) More values other than chunked defined in Transfer-Encoding header leads to decode failure (netty#10321) Set (and override) reserved websocket handshake response headers after custom to avoid duplication (netty#10319) Update GraalVM with JDK 8 and add GraalVM with JDK 11 (netty#10333) Include more details if we throw an IllegalArgumentException because of overflow (netty#10330) SslHandler#wrap to preserve exception if SSLEngine is closed (netty#10327)
ihanyong
pushed a commit
to ihanyong/netty
that referenced
this pull request
Jul 31, 2020
…ads to decode failure (netty#10321) Motivation: `containsValue()` will check if there are multiple values defined in the specific header name, we need to use this method instead of `contains()` for the `Transfer-Encoding` header to cover the case that multiple values defined, like: `Transfer-Encoding: gzip, chunked` Modification: Change from `contains()` to `containsValue()` in `HttpUtil.isTransferEncodingChunked()` method. Result: Fixes netty#10320
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
containsValue()will check if there are multiple values defined in the specific header name, we need to use this method instead ofcontains()for theTransfer-Encodingheader to cover the case that multiple values defined, like:Transfer-Encoding: gzip, chunkedModification:
Change from
contains()tocontainsValue()inHttpUtil.isTransferEncodingChunked()method.Fixes #10320