Allow blocking calls in UnixResolverDnsServerAddressStreamProvider#parse#10935
Merged
Conversation
Motivation:
Internally UnixResolverDnsServerAddressStreamProvider#parse calls FileInputStream.read(...)
when parsing the etcResolverFiles.
This will cause the error below when BlockHound is enabled
reactor.blockhound.BlockingOperationError: Blocking call! java.io.FileInputStream#readBytes
at java.io.FileInputStream.readBytes(FileInputStream.java)
at java.io.FileInputStream.read(FileInputStream.java:255)
Modifications:
- Add whitelist entry to BlockHound configuration
- Add test
Result:
Fixes #10925
normanmaurer
requested changes
Jan 14, 2021
Member
|
@violetagg thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Jan 14, 2021
…rse (#10935) Motivation: Internally UnixResolverDnsServerAddressStreamProvider#parse calls FileInputStream.read(...) when parsing the etcResolverFiles. This will cause the error below when BlockHound is enabled reactor.blockhound.BlockingOperationError: Blocking call! java.io.FileInputStream#readBytes at java.io.FileInputStream.readBytes(FileInputStream.java) at java.io.FileInputStream.read(FileInputStream.java:255) Modifications: - Add whitelist entry to BlockHound configuration - Add test Result: Fixes #10925
ZzxyNn
pushed a commit
to ZzxyNn/netty
that referenced
this pull request
Jan 29, 2021
…rse (netty#10935) Motivation: Internally UnixResolverDnsServerAddressStreamProvider#parse calls FileInputStream.read(...) when parsing the etcResolverFiles. This will cause the error below when BlockHound is enabled reactor.blockhound.BlockingOperationError: Blocking call! java.io.FileInputStream#readBytes at java.io.FileInputStream.readBytes(FileInputStream.java) at java.io.FileInputStream.read(FileInputStream.java:255) Modifications: - Add whitelist entry to BlockHound configuration - Add test Result: Fixes netty#10925
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…rse (netty#10935) Motivation: Internally UnixResolverDnsServerAddressStreamProvider#parse calls FileInputStream.read(...) when parsing the etcResolverFiles. This will cause the error below when BlockHound is enabled reactor.blockhound.BlockingOperationError: Blocking call! java.io.FileInputStream#readBytes at java.io.FileInputStream.readBytes(FileInputStream.java) at java.io.FileInputStream.read(FileInputStream.java:255) Modifications: - Add whitelist entry to BlockHound configuration - Add test Result: Fixes netty#10925
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Internally
UnixResolverDnsServerAddressStreamProvider#parsecallsFileInputStream.read(...)when parsing the
etcResolverFiles.This will cause the error below when
BlockHoundis enabledModifications:
BlockHoundconfigurationResult:
Fixes #10925