Correctly handle fragmentation in JdkZlibDecoder#10948
Merged
Merged
Conversation
Motivation: We had multiple bugs in JdkZlibDecoder which could lead to decoding errors when the data was received in a fragmentated manner. Modifications: - Correctly handle skipping of comments - Correctly handle footer / header decoding - Add unit test that verifies the correct handling of fragmentation Result: Fixes #10875
chrisvest
approved these changes
Jan 18, 2021
normanmaurer
added a commit
that referenced
this pull request
Jan 18, 2021
Motivation: We had multiple bugs in JdkZlibDecoder which could lead to decoding errors when the data was received in a fragmentated manner. Modifications: - Correctly handle skipping of comments - Correctly handle footer / header decoding - Add unit test that verifies the correct handling of fragmentation Result: Fixes #10875
ZzxyNn
pushed a commit
to ZzxyNn/netty
that referenced
this pull request
Jan 29, 2021
Motivation: We had multiple bugs in JdkZlibDecoder which could lead to decoding errors when the data was received in a fragmentated manner. Modifications: - Correctly handle skipping of comments - Correctly handle footer / header decoding - Add unit test that verifies the correct handling of fragmentation Result: Fixes netty#10875
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: We had multiple bugs in JdkZlibDecoder which could lead to decoding errors when the data was received in a fragmentated manner. Modifications: - Correctly handle skipping of comments - Correctly handle footer / header decoding - Add unit test that verifies the correct handling of fragmentation Result: Fixes netty#10875
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We had multiple bugs in JdkZlibDecoder which could lead to decoding errors when the data was received in a fragmentated manner.
Modifications:
Result:
Fixes #10875