Fix issue if encoding is enabled but not used#11358
Merged
Merged
Conversation
Contributor
Author
|
I thought something else was wrong in #11093 but managed to convince myself that it was fine. Turns out that there are similar problems for HTTP/1.0 and requests that don't set an accept-encoding. |
trustin
reviewed
Jun 5, 2021
Member
trustin
left a comment
trustin
left a comment
There was a problem hiding this comment.
Thanks for fixing this, @stuartwdouglas. Left two nits.
Contributor
Author
|
Fixed, no idea how that happened. |
normanmaurer
approved these changes
Jun 7, 2021
Member
normanmaurer
left a comment
normanmaurer
left a comment
There was a problem hiding this comment.
Thanks a lot @stuartwdouglas
normanmaurer
pushed a commit
that referenced
this pull request
Jun 7, 2021
Motivation: Fixes an IllegalReferenceCountException Modification: Retained the buffers so the encoder works correctly. Result: Fixes #11357
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: Fixes an IllegalReferenceCountException Modification: Retained the buffers so the encoder works correctly. Result: Fixes netty#11357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Fixes an IllegalReferenceCountException
Modification:
Retained the buffers so the encoder works correctly.
Result:
Fixes #11357