CombinedChannelDuplexHandler.removeOutboundHandler() cause connect(..…#11414
Merged
Conversation
….) to not pass the correct parameters Motivation: Due a bug we did not pass the correct remote and localaddress to the next handler if the outbound portion of the CombinedChannelDuplexHandler was removed Modifications: - Call the correct connect(...) method - Refactor tests to test that the parameters are correctly passed on - Remvoe some code duplication in the tests Result: CombinedChannelDuplexHandler correctly pass parameters on
chrisvest
approved these changes
Jun 24, 2021
normanmaurer
added a commit
that referenced
this pull request
Jun 24, 2021
….) to not pass the correct parameters (#11414) Motivation: Due a bug we did not pass the correct remote and localaddress to the next handler if the outbound portion of the CombinedChannelDuplexHandler was removed Modifications: - Call the correct connect(...) method - Refactor tests to test that the parameters are correctly passed on - Remvoe some code duplication in the tests Result: CombinedChannelDuplexHandler correctly pass parameters on
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
….) to not pass the correct parameters (netty#11414) Motivation: Due a bug we did not pass the correct remote and localaddress to the next handler if the outbound portion of the CombinedChannelDuplexHandler was removed Modifications: - Call the correct connect(...) method - Refactor tests to test that the parameters are correctly passed on - Remvoe some code duplication in the tests Result: CombinedChannelDuplexHandler correctly pass parameters on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….) to not pass the correct parameters
Motivation:
Due a bug we did not pass the correct remote and localaddress to the next handler if the outbound portion of the CombinedChannelDuplexHandler was removed
Modifications:
Result:
CombinedChannelDuplexHandler correctly pass parameters on