Delay initialization of io.netty.handler.codec.compression.BrotliDecoder to runtime#11428
Conversation
|
@gradinac can you sign our icla: https://netty.io/s/icla ? |
|
@normanmaurer I've requested an approval to sign it - will sign it and let you know as soon as I get a green light on it |
|
@chrisvest any idea why the build would fail with graal ? |
|
Looking at surefire reports of the build, this seems to be a crash in the JVM: These failures usually produce a This is most likely a bug and will probably not happen again if we re-run the job. One thing I've noticed is that the GraalVM version used in the gate is very old: It may be worth bumping it to 21.1 (or wait a bit more for 21.2 to be released) - the cause of this crash might have already been addressed in the newest version |
|
@normanmaurer I have signed the ICLA |
|
@gradinac thanks a lot! |
…der to runtime (#11428) Motivation: Including codec-http in the project and building a native-image out of it using a GraalVM 21.2 nightly can result in a failure. Modification: By delaying the initialization of `io.netty.handler.codec.compression.BrotliDecoder` to runtime, native-image will not try to eagerly initialize the class during the image build, avoiding the build failure described in the issue. Result: Fixes #11427
|
@normanmaurer thank you very much for reviewing and merging this PR! :) |
…der to runtime (netty#11428) Motivation: Including codec-http in the project and building a native-image out of it using a GraalVM 21.2 nightly can result in a failure. Modification: By delaying the initialization of `io.netty.handler.codec.compression.BrotliDecoder` to runtime, native-image will not try to eagerly initialize the class during the image build, avoiding the build failure described in the issue. Result: Fixes netty#11427
Motivation:
See #11427
Modification:
By delaying the initialization of
io.netty.handler.codec.compression.BrotliDecoderto runtime, native-image will not try to eagerly initialize the class during the image build, avoiding the build failure described in the issue.Fixes #11427