Don't set the writerIndex to incorrect value when scattering reads ar…#12076
Merged
Conversation
…e used for datagrams Motivation: Due a bug we did set the writerIndex(...) of datagrams to an incorrect value sometimes when scattering reads are used. Modifications: - Remove incorrect call to writerIndex(...) - Add comment Result: Correct writerIndex is used
Member
Author
|
@chrisvest great catch! |
chrisvest
approved these changes
Feb 4, 2022
chrisvest
pushed a commit
that referenced
this pull request
Feb 4, 2022
…e used for datagrams (#12076) Motivation: Due a bug we did set the writerIndex(...) of datagrams to an incorrect value sometimes when scattering reads are used. Modifications: - Remove incorrect call to writerIndex(...) - Add comment Result: Correct writerIndex is used
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…e used for datagrams (netty#12076) Motivation: Due a bug we did set the writerIndex(...) of datagrams to an incorrect value sometimes when scattering reads are used. Modifications: - Remove incorrect call to writerIndex(...) - Add comment Result: Correct writerIndex is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e used for datagrams
Motivation:
Due a bug we did set the writerIndex(...) of datagrams to an incorrect value sometimes when scattering reads are used.
Modifications:
Result:
Correct writerIndex is used