Fix typo in Blockhound integration#12414
Merged
Merged
Conversation
Motivation: We have a typo in the list of places where Blockhound should allow blocking calls. This caused Blockhound to sometimes flag NetUtil as making blocking calls, instead of allowing them. Modification: Fix the typo in the allow-list to match the NetUtil class. Result: Fixes netty#12411
normanmaurer
approved these changes
May 19, 2022
normanmaurer
pushed a commit
that referenced
this pull request
May 19, 2022
Motivation: We have a typo in the list of places where Blockhound should allow blocking calls. This caused Blockhound to sometimes flag NetUtil as making blocking calls, instead of allowing them. Modification: Fix the typo in the allow-list to match the NetUtil class. Result: Fixes #12411
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: We have a typo in the list of places where Blockhound should allow blocking calls. This caused Blockhound to sometimes flag NetUtil as making blocking calls, instead of allowing them. Modification: Fix the typo in the allow-list to match the NetUtil class. Result: Fixes netty#12411
franz1981
pushed a commit
to franz1981/netty
that referenced
this pull request
Aug 22, 2022
Motivation: We have a typo in the list of places where Blockhound should allow blocking calls. This caused Blockhound to sometimes flag NetUtil as making blocking calls, instead of allowing them. Modification: Fix the typo in the allow-list to match the NetUtil class. Result: Fixes netty#12411
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We have a typo in the list of places where Blockhound should allow blocking calls.
This caused Blockhound to sometimes flag NetUtil as making blocking calls, instead of allowing them.
Modification:
Fix the typo in the allow-list to match the NetUtil class.
Result:
Fixes #12411