Make handler tests faster by caching self-signed certificates#14344
Merged
Make handler tests faster by caching self-signed certificates#14344
Conversation
Motivation: In Netty 4.1, we test our SSL code with RSA keys. These keys are expensive to generate, so it's desirable to cache and reuse them across multiple tests when possible. Modification: Add a CachedSelfSignedCertificate holder class to the test code. Use the cached certificate in every test that 1) does not already cache its certificates, and 2) only uses one certificate, and 3) were using the default SelfSignedCertificate constructor. Result: These tests, many of which are parameterized in various ways, now run much faster, shaving minutes off our builds.
chrisvest
added a commit
that referenced
this pull request
Sep 19, 2024
Motivation: In Netty 4.2, we test our SSL code with RSA keys. These keys are expensive to generate, so it's desirable to cache and reuse them across multiple tests when possible. Modification: Add a CachedSelfSignedCertificate holder class to the test code. Use the cached certificate in every test that 1) does not already cache its certificates, and 2) only uses one certificate, and 3) were using the default SelfSignedCertificate constructor. Result: These tests, many of which are parameterized in various ways, now run much faster, shaving minutes off our builds.
chrisvest
added a commit
that referenced
this pull request
Sep 28, 2024
Motivation: In Netty 5, we currently test our SSL code with RSA keys. These keys are expensive to generate, so it's desirable to cache and reuse them across multiple tests when possible. Modification: Add a CachedSelfSignedCertificate holder class to the test code. Use the cached certificate in every test that 1) does not already cache its certificates, and 2) only uses one certificate, and 3) were using the default SelfSignedCertificate constructor. Result: These tests, many of which are parameterized in various ways, now run much faster, shaving minutes off our builds. This is a forward port of #14344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In Netty 4.1, we test our SSL code with RSA keys.
These keys are expensive to generate, so it's desirable to cache and reuse them across multiple tests when possible.
Modification:
Add a CachedSelfSignedCertificate holder class to the test code. Use the cached certificate in every test that 1) does not already cache its certificates, and 2) only uses one certificate, and 3) were using the default SelfSignedCertificate constructor.
Result:
These tests, many of which are parameterized in various ways, now run much faster, shaving minutes off our builds.