Decrease usedMemory of magazine when the chunk get deallocated#14508
Merged
normanmaurer merged 2 commits intoNov 27, 2024
Conversation
laosijikaichele
force-pushed
the
4.1-chunk-deallocate-usedmemory
branch
from
ba2ffaf to
03fe6a5
Compare
normanmaurer
approved these changes
Nov 27, 2024
normanmaurer
added a commit
that referenced
this pull request
Nov 27, 2024
…ed to central queue (#14508) Motivation: For `AdaptivePoolingAllocator`, the `magazine.usedMemory` should be decreased when the chunk be deallocated or be offered to the `centralQueue`. Modification: Decreased the `magazine.usedMemory` when the chunk be deallocated or be offered to the `centralQueue`. Result: The `magazine.usedMemory` becomes more accurate. --------- Co-authored-by: laosijikaichele <laosijikaichele> Co-authored-by: Norman Maurer <norman_maurer@apple.com>
normanmaurer
added a commit
that referenced
this pull request
Nov 27, 2024
#14515) …ed to central queue (#14508) Motivation: For `AdaptivePoolingAllocator`, the `magazine.usedMemory` should be decreased when the chunk be deallocated or be offered to the `centralQueue`. Modification: Decreased the `magazine.usedMemory` when the chunk be deallocated or be offered to the `centralQueue`. Result: The `magazine.usedMemory` becomes more accurate. Co-authored-by: old driver <29225782+laosijikaichele@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
For
AdaptivePoolingAllocator, themagazine.usedMemoryshould be decreased when the chunk be deallocated or be offered to thecentralQueue.Modification:
Decreased the
magazine.usedMemorywhen the chunk be deallocated or be offered to thecentralQueue.Result:
The
magazine.usedMemorybecomes more accurate.