Spdy: Add UnknownFrame parsing support for SpdyFrameCodec.#14561
Merged
Conversation
Motivation: To make our codec more flexible we should add support for unknown frames in SPDY. Modifications: - Add SpdyFrameDecoderExtendedDelegate that supports unknown frames - Add new constructor and protected method to SpdyFrameCodec that makes it easy to support it Result: More flexible SPDY implementation. Co-authored-by: Norman Maurer <norman_maurer@apple.com>
Member
Author
|
/cc @He-Pin PTAL |
normanmaurer
commented
Dec 12, 2024
He-Pin
reviewed
Dec 12, 2024
He-Pin
reviewed
Dec 12, 2024
Member
Author
|
@He-Pin I think this is ready to go... PTAL |
He-Pin
reviewed
Dec 12, 2024
| public void readUnknownFrame(int frameType, byte flags, ByteBuf payload) { | ||
| read = true; | ||
| SpdyUnknownFrame spdyUnknownFrame = new DefaultSpdyUnknownFrame(frameType, flags, payload); | ||
| ctx.fireChannelRead(spdyUnknownFrame); |
Contributor
There was a problem hiding this comment.
how about adding a protected method: createSpdyUnknownFrame, then I can override it.
Member
Author
There was a problem hiding this comment.
Sure I can do this if you need it.
He-Pin
reviewed
Dec 12, 2024
He-Pin
reviewed
Dec 12, 2024
Member
Author
|
@He-Pin PTAL again |
He-Pin
reviewed
Dec 12, 2024
| } | ||
|
|
||
| protected SpdyUnknownFrame newSpdyUnknownFrame(int frameType, byte flags, ByteBuf payload) { | ||
| return new DefaultSpdyUnknownFrame(frameType, flags, payload); |
Contributor
There was a problem hiding this comment.
Thanks, but I think this can better be a SpdyFrame , which only is a maker interface, otherwise users will have to implement the ByteBufHolder, and In our implementation, CustFrame extends SpdyFrame.
Contributor
|
LGTM |
Contributor
|
The milestone should be 4.1.116.Final now. |
He-Pin
reviewed
Dec 13, 2024
| return false; | ||
| } | ||
| if (delegate instanceof SpdyFrameDecoderExtendedDelegate) { | ||
| ByteBuf data = buffer.alloc().buffer(length); |
Contributor
There was a problem hiding this comment.
what about using buffer.readSlice here?
Member
Author
There was a problem hiding this comment.
Yes we could use readRetainedSlice(...). But let's do this in a followup as its true for other methods as well.
Contributor
|
Thanks |
normanmaurer
added a commit
that referenced
this pull request
Dec 13, 2024
Motivation: To make our codec more flexible we should add support for unknown frames in SPDY. Modifications: - Add default method to SpdyFrameDecoderDelegate to support unknown frames - Add new constructor and protected method to SpdyFrameCodec that makes it easy to support it Result: More flexible SPDY implementation. --------- Co-authored-by: 虎鸣 <hepin.p@alibaba-inc.com>
normanmaurer
added a commit
that referenced
this pull request
Dec 13, 2024
…14569) Motivation: To make our codec more flexible we should add support for unknown frames in SPDY. Modifications: - Add default method to SpdyFrameDecoderDelegate to support unknown frames - Add new constructor and protected method to SpdyFrameCodec that makes it easy to support it Result: More flexible SPDY implementation. Co-authored-by: 虎鸣 <hepin.p@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
To make our codec more flexible we should add support for unknown frames in SPDY.
Modifications:
Result:
More flexible SPDY implementation.