Timer: Add callback users can override to cleanup on cancellation#14571
Merged
Conversation
Motiviation: When a TimerTask is cancelled it is useful to sometimes do some cleanup. Modification: Add new default method that people can use Result: Fixes #14566
Member
Author
|
/cc @He-Pin |
Contributor
|
I think this should be backported to 4.1.x too. |
Member
Author
|
@He-Pin we could only do this in 4.1 by adding some extra interface or abstract base-class tho |
Contributor
|
That's true, we can live with that, an extra instanceOf seems will not hurt much performance of the Timer. |
bryce-anderson
approved these changes
Dec 13, 2024
He-Pin
reviewed
Dec 16, 2024
| * | ||
| * @param timeout a handle which is associated with this task | ||
| */ | ||
| default void cancelled(Timeout timeout) { |
Contributor
There was a problem hiding this comment.
should this method be onCancelled or postCancelled?
He-Pin
reviewed
Dec 16, 2024
| } else { | ||
| timer.pendingTimeouts.decrementAndGet(); | ||
| } | ||
| task.cancelled(this); |
Contributor
There was a problem hiding this comment.
we should let user know, never do heavy cleanup thing here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motiviation:
When a TimerTask is cancelled it is useful to sometimes do some cleanup.
Modification:
Add new default method that people can use
Result:
Fixes #14566