Adaptive: Correctly restore allocatedBytes value on failure#14577
Merged
Conversation
Motivation: We need to restore the allocatedBytes value to the previous value on failure to ensure we not mess up state. Modifications: Restore value on failure Result: Correctly recover from failure
normanmaurer
force-pushed
the
failure_handling
branch
from
be67d7e to
9d28674
Compare
Member
Author
|
/cc @johnou |
johnou
approved these changes
Dec 13, 2024
Contributor
johnou
left a comment
johnou
left a comment
There was a problem hiding this comment.
lgtm thanks @normanmaurer!
franz1981
approved these changes
Dec 13, 2024
normanmaurer
added a commit
that referenced
this pull request
Dec 13, 2024
Motivation: We need to restore the allocatedBytes value to the previous value on failure to ensure we not mess up state. Modifications: Restore value on failure Result: Correctly recover from failure
normanmaurer
added a commit
that referenced
this pull request
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to restore the allocatedBytes value to the previous value on failure to ensure we not mess up state.
Modifications:
Restore value on failure
Result:
Correctly recover from failure