Adapt: Don't fail when we run on a host with 1 core (#14582)#14584
Merged
Conversation
Motivation: We require that the minimum queue size is 2 and use the number of cores as default value which can be less. Modifications: If we see less then 2 cores just use 2 as default size Result: Fixes #14579
| */ | ||
| private static final int CENTRAL_QUEUE_CAPACITY = SystemPropertyUtil.getInt( | ||
| "io.netty.allocator.centralQueueCapacity", NettyRuntime.availableProcessors()); | ||
| private static final int CENTRAL_QUEUE_CAPACITY = Math.min(2, SystemPropertyUtil.getInt( |
Contributor
There was a problem hiding this comment.
It should be Math.max
There was a problem hiding this comment.
@normanmaurer I'm afraid that's right. Math.max should have been used here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We require that the minimum queue size is 2 and use the number of cores as default value which can be less.
Modifications:
If we see less then 2 cores just use 2 as default size
Result:
Fixes #14579