Skip to content

IoUring: Add IoUringChannelOption.IOSQE_ASYNC#14633

Merged
normanmaurer merged 2 commits into
4.2from
ioseq_async
Jan 13, 2025
Merged

IoUring: Add IoUringChannelOption.IOSQE_ASYNC#14633
normanmaurer merged 2 commits into
4.2from
ioseq_async

Conversation

@normanmaurer
Copy link
Copy Markdown
Member

Motivation:

Sometimes it might be benefitial to use IOSQE_ASYNC when submitting stuff to the ring.

Modifications:

Add IoUringChannelOption.IOSQE_ASYNC to enable it per Channel

Result:

More flexibility when using io_uring

Motivation:

Sometimes it might be benefitial to use IOSQE_ASYNC when submitting stuff to the ring.

Modifications:

Add IoUringChannelOption.IOSQE_ASYNC to enable it per Channel

Result:

More flexibility when using io_uring
@normanmaurer
Copy link
Copy Markdown
Member Author

/cc @dreamlike-ocean

@normanmaurer normanmaurer added this to the 4.2.0.Final milestone Dec 31, 2024
@chrisvest
Copy link
Copy Markdown
Member

Sometimes it might be benefitial to use IOSQE_ASYNC when submitting stuff to the ring.

Is it beneficial on a channel level or only certain types of operations?

It effectively doubles the test matrix, so I just want to be sure it's worth it.

@dreamlike-ocean
Copy link
Copy Markdown
Contributor

There are really too many flags that can be configured in the io_uring_sqe.
I think it would be nice to have a custom post or pre-processor for IoUringOps that can be provided for users to use.

@normanmaurer
Copy link
Copy Markdown
Member Author

There are really too many flags that can be configured in the io_uring_sqe.

I think it would be nice to have a custom post or pre-processor for IoUringOps that can be provided for users to use.

I think this is overkill for now and might mess up things easily by the user

@normanmaurer
Copy link
Copy Markdown
Member Author

Sometimes it might be benefitial to use IOSQE_ASYNC when submitting stuff to the ring.

Is it beneficial on a channel level or only certain types of operations?

It effectively doubles the test matrix, so I just want to be sure it's worth it.

I think it's mostly for read / accept / recv. So maybe we should only apply it for these ? Just wanted to keep it simple

@normanmaurer
Copy link
Copy Markdown
Member Author

@franz1981 @chrisvest WDYT ?

@normanmaurer
Copy link
Copy Markdown
Member Author

@chrisvest related to this #14650 which allows to configure the number of workers for unbounded work (which is what we want)

@normanmaurer normanmaurer merged commit e5e5230 into 4.2 Jan 13, 2025
@normanmaurer normanmaurer deleted the ioseq_async branch January 13, 2025 20:41
@normanmaurer normanmaurer modified the milestones: 4.2.0.Final, 4.2.0.RC2 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants