Revert "IoUring: Remove delayed close logic as its not needed (#14540)"#14665
Merged
Conversation
Member
Author
|
So it turns out I was wrong by removing this before after talking to @axboe. This also fixes a bug which did not correctly handle the delaying of close for write errors. |
normanmaurer
commented
Jan 14, 2025
Member
Author
There was a problem hiding this comment.
notify was always false
normanmaurer
force-pushed
the
delayed_close
branch
from
a7cbd09 to
5b6f184
Compare
Member
Author
|
Before this change I typically did see buffers that were delivered after the pipeline was teared down during benchmarks |
normanmaurer
force-pushed
the
delayed_close
branch
from
832556c to
d6f2d6e
Compare
Motivation: This reverts commit ed3566c and slightly changes it a bit to ensure write error handlings also take account delayed close Modifications: - Revert ed3566c - Correctly handle delayed close for write errors Result: No more problems of tearing down the pipeline before all read / write completions are observed
normanmaurer
force-pushed
the
delayed_close
branch
from
d6f2d6e to
676933a
Compare
chrisvest
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
This reverts commit ed3566c and slightly changes it a bit to ensure write error handlings also take account delayed close
Modifications:
Result:
No more problems of tearing down the pipeline before all read / write completions are observed