IoUring: try to enable IORING_SETUP_SUBMIT_ALL when supported by the running system#14677
Merged
Conversation
normanmaurer
force-pushed
the
submit_all
branch
2 times, most recently
from
759ff09 to
9e9902b
Compare
Member
Author
|
I think this should also be ported to the incubator branch |
chrisvest
reviewed
Jan 15, 2025
normanmaurer
force-pushed
the
submit_all
branch
from
9e9902b to
94bfb4c
Compare
normanmaurer
changed the title
…running system Motivation When porting io_uring to the main branch we introduced the use of IORING_SETUP_SUBMIT_ALL which makes a lot of sense. Unfortunally we never ended up actually enable it as we guarded it with an ifdef that was always false due the usage of an outdated io_uring.h file. Motifications: - Check if IORING_SETUP_SUBMIT_ALL is supported by the running system and if this is the case enable it - Update the io_uring.h file Result: IORING_SETUP_SUBMIT_ALL is used when possible
normanmaurer
force-pushed
the
submit_all
branch
from
94bfb4c to
3d3ab97
Compare
Member
Author
|
Merging this as I need some part of it for https://github.com/netty/netty/pull/14699/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When porting io_uring to the main branch we introduced the use of IORING_SETUP_SUBMIT_ALL which makes a lot of sense. Unfortunally we never ended up actually enable it as we guarded it with an ifdef that was always false due the usage of an outdated io_uring.h file.
Motifications:
Result:
IORING_SETUP_SUBMIT_ALL is used when possible