IoUring: Submit after completion queue was processed#14696
Merged
Conversation
Motivation: We should try to submit one more time after we did run all completions. Otherwise we might introduce latency that will hurt performance. Modifications: Add one more submit call. Result: Better troughput. Before the change: ``` Destination: [127.0.0.1]:8088 Interface lo address [127.0.0.1]:0 Using interface lo to connect to [127.0.0.1]:8088 Ramped up to 1 connections. Total data sent: 134066.2 MiB (140578586624 bytes) Total data received: 134066.1 MiB (140578537472 bytes) Bandwidth per channel: 74755.196⇅ Mbps (9344399.5 kBps) Aggregate bandwidth: 37377.591↓, 37377.605↑ Mbps Packet rate estimate: 3424327.9↓, 3208145.5↑ (12↓, 45↑ TCP MSS/op) Test duration: 30.0883 s. ``` After this change: ``` Destination: [127.0.0.1]:8088 Interface lo address [127.0.0.1]:0 Using interface lo to connect to [127.0.0.1]:8088 Ramped up to 1 connections. Total data sent: 250820.2 MiB (263004028928 bytes) Total data received: 250812.7 MiB (262996131840 bytes) Bandwidth per channel: 139956.971⇅ Mbps (17494621.4 kBps) Aggregate bandwidth: 69977.435↓, 69979.536↑ Mbps Packet rate estimate: 6406626.3↓, 6006391.8↑ (12↓, 45↑ TCP MSS/op) Test duration: 30.0664 s. ```
Contributor
|
I like it, and makes sense |
Contributor
|
The same could happen after we drain completion on writability changed |
Member
Author
Yeah but these will be handled by this submit as well... we also don't want to call submit too often as it's a syscall |
franz1981
approved these changes
Jan 18, 2025
Contributor
franz1981
left a comment
There was a problem hiding this comment.
Looks great 😃 you're rocking here - let's make this fly
chrisvest
approved these changes
Jan 18, 2025
Member
|
How's it looking compared to NIO and epoll now, in this test? |
Member
Author
4-5% slower... almost there ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We should try to submit one more time after we did run all completions. Otherwise we might introduce latency that will hurt performance.
Modifications:
Add one more submit call.
Result:
Better troughput.
Before the change:
After this change: