Skip to content

Add support for ML-KEM in CertificateBuilder#15012

Merged
chrisvest merged 2 commits into
netty:4.2from
chrisvest:4.2-ml-kem
Apr 14, 2025
Merged

Add support for ML-KEM in CertificateBuilder#15012
chrisvest merged 2 commits into
netty:4.2from
chrisvest:4.2-ml-kem

Conversation

@chrisvest
Copy link
Copy Markdown
Member

Motivation:
Java 24 added support for the ML-DSA and ML-KEM post-quantum algorithms. In a previous PR we added support for self-signed ML-DSA. This completes our support for these algorithms in CertificateBuilder.

Modification:

  • Add the FIPS 203 ML-KEM-512, ML-KEM-768, and ML-KEM-1024 algorithms to CertificateBuilder.Algorithm.
  • Add checks that these keys are not used for signing.
  • Add support for ML-DSA cert bundles to be used as issuers.
  • Simplify the Algorithm.generateKeyPair method.

Result:
You can now create certs with ML-KEM keys, and you can now use ML-DSA as issuer keys.

Motivation:
Java 24 added support for the ML-DSA and ML-KEM post-quantum algorithms.
In a previous PR we added support for self-signed ML-DSA.
This completes our support for these algorithms in CertificateBuilder.

Modification:
- Add the FIPS 203 ML-KEM-512, ML-KEM-768, and ML-KEM-1024 algorithms to CertificateBuilder.Algorithm.
- Add checks that these keys are not used for signing.
- Add support for ML-DSA cert bundles to be used as issuers.
- Simplify the Algorithm.generateKeyPair method.

Result:
You can now create certs with ML-KEM keys, and you can now use ML-DSA as issuer keys.
@chrisvest chrisvest added this to the 4.2.1.Final milestone Apr 8, 2025
@chrisvest chrisvest requested a review from normanmaurer April 8, 2025 18:29
Comment thread pom.xml
<log4j2.version>2.23.1</log4j2.version>
<enforcer.plugin.version>3.0.0</enforcer.plugin.version>
<junit.version>5.9.0</junit.version>
<junit.version>5.12.1</junit.version>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump for the JRE.JAVA_24 enum constant.

@chrisvest chrisvest merged commit 35333e5 into netty:4.2 Apr 14, 2025
24 of 25 checks passed
@chrisvest chrisvest deleted the 4.2-ml-kem branch April 14, 2025 22:39
chrisvest added a commit to chrisvest/netty that referenced this pull request Apr 14, 2025
Motivation:
Java 24 added support for the ML-DSA and ML-KEM post-quantum algorithms.
In a previous PR we added support for self-signed ML-DSA. This completes
our support for these algorithms in CertificateBuilder.

Modification:
- Add the FIPS 203 ML-KEM-512, ML-KEM-768, and ML-KEM-1024 algorithms to
CertificateBuilder.Algorithm.
- Add checks that these keys are not used for signing.
- Add support for ML-DSA cert bundles to be used as issuers.
- Simplify the Algorithm.generateKeyPair method.

Result:
You can now create certs with ML-KEM keys, and you can now use ML-DSA as
issuer keys.
normanmaurer pushed a commit that referenced this pull request Apr 15, 2025
Motivation:
Java 24 added support for the ML-DSA and ML-KEM post-quantum algorithms.
In a previous PR we added support for self-signed ML-DSA. This completes
our support for these algorithms in CertificateBuilder.

Modification:
- Add the FIPS 203 ML-KEM-512, ML-KEM-768, and ML-KEM-1024 algorithms to
CertificateBuilder.Algorithm.
- Add checks that these keys are not used for signing.
- Add support for ML-DSA cert bundles to be used as issuers.
- Simplify the Algorithm.generateKeyPair method.

Result:
You can now create certs with ML-KEM keys, and you can now use ML-DSA as
issuer keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant