Fix IllegalReferenceCountException on invalid upgrade response#15602
Merged
normanmaurer merged 2 commits intonetty:4.2from Sep 2, 2025
Merged
Fix IllegalReferenceCountException on invalid upgrade response#15602normanmaurer merged 2 commits intonetty:4.2from
normanmaurer merged 2 commits intonetty:4.2from
Conversation
Motivation: When HttpClientUpgradeHandler receives a response with an invalid upgrade header, it would release the response but still keep it in the `out` list. Downstream code would then get an IllegalReferenceCountException when releasing the response. Modification: Remove unnecessary release. I don't think it's ever appropriate. Result: No IllegalReferenceCountException. Found by fuzzing
Member
|
@yawkat please fix check style |
Contributor
|
@normanmaurer will https://autofix.ci help? |
Contributor
Author
|
I think for that it would require an autoformatter, not just a check |
normanmaurer
pushed a commit
that referenced
this pull request
Sep 2, 2025
Motivation: When HttpClientUpgradeHandler receives a response with an invalid upgrade header, it would release the response but still keep it in the `out` list. Downstream code would then get an IllegalReferenceCountException when releasing the response. Modification: Remove unnecessary release. I don't think it's ever appropriate. Result: No IllegalReferenceCountException. Found by fuzzing
normanmaurer
added a commit
that referenced
this pull request
Sep 2, 2025
… (#15606) Motivation: When HttpClientUpgradeHandler receives a response with an invalid upgrade header, it would release the response but still keep it in the `out` list. Downstream code would then get an IllegalReferenceCountException when releasing the response. Modification: Remove unnecessary release. I don't think it's ever appropriate. Result: No IllegalReferenceCountException. Found by fuzzing --------- Co-authored-by: Jonas Konrad <jonas.konrad@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
When HttpClientUpgradeHandler receives a response with an invalid upgrade header, it would release the response but still keep it in the
outlist. Downstream code would then get an IllegalReferenceCountException when releasing the response.Modification:
Remove unnecessary release. I don't think it's ever appropriate.
Result:
No IllegalReferenceCountException.
Found by fuzzing