Expose the list of supported io_uring features#15785
Merged
Merged
Conversation
Motivation: Users have to enable debug logging to be aware of any unsupported feature which affect performance: it would be nice to make it more friendly via IoUring::toString Modification: Centralize the formatting of the list of supported features while enabling toString to use it Result: More user-friendly detection of unsupported features
franz1981
requested review from
chrisvest and
normanmaurer
and removed request for
chrisvest
9 tasks
Member
|
@franz1981 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Users have to enable debug logging to be aware of any unsupported feature which affect performance: it would be nice to make it more friendly via IoUring::toString
Modification:
Centralize the formatting of the list of supported features while enabling toString to use it
Result:
More user-friendly detection of unsupported features